Repository navigation
feat: add warning message when trying to delete active template - #10142
Merged
Merged
Conversation
buenos-nachos
marked this pull request as ready for review
October 9, 2023 18:52
buenos-nachos
requested review from
a team and
aslilac
and removed request for
a team
October 9, 2023 18:53
aslilac
reviewed
Oct 9, 2023
| return ["workspaces", query] as const; | ||
| } | ||
|
|
||
| export function workspacesByQuery(query: string) { |
Member
There was a problem hiding this comment.
I think we've just been re-using the API function name for these, so this one would be workspaces
| const queryText = `template:${templateName}`; | ||
| const workspaceCountQuery = useQuery({ | ||
| ...workspacesByQuery(queryText), | ||
| select: (res) => res.count, |
aslilac
approved these changes
Oct 9, 2023
Comment on lines
+35
to
+40
| type TemplateMenuProps = { | ||
| templateName: string; | ||
| templateVersion: string; | ||
| templateId: string; | ||
| onDelete: () => void; | ||
| }> = ({ templateName, templateVersion, onDelete }) => { | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9348 and builds upon #10111 from last Friday
Changes made