Repository navigation
chore: rename AwaitTemplateVersionJobCompleted and AwaitWorkspaceBuildJobCompleted - #10003
Merged
Merged
Conversation
…uildJobCompleted`
aslilac
requested review from
a team and
ammario
and removed request for
a team and
ammario
October 2, 2023 23:12
ammario
approved these changes
Oct 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not immediately clear what these are actually waiting for under their old names, and becomes ambiguous if there are multiple states you might want to wait for in a test.
I ended up wanting to rename these while working on something else, but the diff is big enough I felt like I needed to break it out into a separate change.