Skip to content

chore: rename AwaitTemplateVersionJobCompleted and AwaitWorkspaceBuildJobCompleted - #10003

Merged
aslilac merged 4 commits into
mainfrom
AwaitTemplateVersionJobCompleted
Oct 3, 2023
Merged

aslilac merged 4 commits into
mainfrom
AwaitTemplateVersionJobCompleted

Conversation

@aslilac

@aslilac aslilac commented Oct 2, 2023

Copy link
Copy Markdown
Member

It's not immediately clear what these are actually waiting for under their old names, and becomes ambiguous if there are multiple states you might want to wait for in a test.

I ended up wanting to rename these while working on something else, but the diff is big enough I felt like I needed to break it out into a separate change.

@aslilac
aslilac requested review from a team and ammario and removed request for a team and ammario October 2, 2023 23:12
@aslilac
aslilac merged commit c194119 into main Oct 3, 2023
@aslilac
aslilac deleted the AwaitTemplateVersionJobCompleted branch October 3, 2023 17:02
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants