Skip to content

health check endpoint: do not show healthy: false if Coder falls back to websockets #9470

Closed

Description

@bpmct

If upgrade: derp doesn't work, Coder passively falls back to WebSockets. This is slightly slower but not significant to my knowledge. We should not show errors in this case, but perhaps a warning?

Activity

  1. matifali commented on Aug 31, 2023

    @matifali
    Contributor

    @bpmct this looks related to #8966 , also can you add it to #8971?

  2. bpmct commented on Aug 31, 2023

    @bpmct
    MemberAuthor

    It is related, but slightly different :) added to the umbrella issue

  3. added this to the healthcheck GA milestone on Sep 19, 2023
  4. added
    s3Bugs that confuse, annoy, or are purely cosmetic
    on Oct 2, 2023
  5. self-assigned this
    on Nov 10, 2023
  6. mtojek commented on Nov 10, 2023

    @mtojek
    Member

    I'm going with this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

s3Bugs that confuse, annoy, or are purely cosmetic

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions