Repository navigation
Closed
Description
This is a sub-epic of User Support that represents the initial user support items needed for the Beta Release.
Create:
POST /users
email, username, password, organization_id
returns user
Read:
GET /users
params: offset?: int, limit?: int ,search?: string, after_user?: uuid
returns User[]
GET /users/:userid
Update:
PUT /users/:userid/profile (userid can be me)
body: email, username, name?
returns user
Delete/Suspend:
PUT /users/:userid/suspend
returns User
- Add User Management (with default org) #195
- Basic CRUD operations for Users #198
- Replace User Context with User machine #435
- Nav Bar - Create a view for Admins to see all the users and orgs in their site #591
- Frontend Users Read - Basic Table #592
- Add API endpoint that allows paging for users #594
- Add support for user details (CRUD) #596
- Add API support for user CRUD operations #598
- Frontend User Update - Reset Password #733
- Frontend User Create #734
- Frontend User Delete #738
- Frontend User Update - Role #739
- Load users from the API #1216
- Add update user password endpoint #1309
- Support assigning and changing users roles in the UI #602
- Allow super admins to change a user's password and see it in plain text in order to send it to the user. #666
- CLI support for User CRUD operations #213
- Feel free to create/modify issues.
- Please add points and tag new issues with the epic they belong to
- Please let EM or PM know if there is a reason something should NOT be in this milestone/epic IF it changes the intent of the Community MVP delivery items in the Scoping doc so we can adjust accordingly or discuss
Metadata
Metadata
Assignees
Labels
No labels
Activity
misskniss commentedon Apr 1, 2022
@presleyp Thank you for pointing these!
Emyrk commentedon Apr 22, 2022
@presleyp @BrunoQuaresma @kylecarbs in v1 when we delete users, it has an impact on things like the audit log. The audit log references by user uuid, but when deleted, you lose all that info.
I think we should
suspendaccounts instead. See https://docs.github.com/en/enterprise-server@3.1/admin/user-management/managing-users-in-your-enterprise/suspending-and-unsuspending-usersSo instead of deleting an account, an admin can suspend an account. This will prevent the user from doing any action on the site until they are unsuspended. When an account is suspended, we treat it like deleted from all UI. I imagine we can have a section to see "All suspended accounts".
Thoughts?
kylecarbs commentedon Apr 22, 2022
Right now we have a deleted column on workspaces, and we could do the same for users.
Suspend makes more sense for users, because you'd never want to allow another user with that email.
presleyp commentedon Apr 22, 2022
Sounds good to me! Just let me know if I need to get the list of users any differently to make sure I'm not getting the suspended ones, and how to suspend a user.
BrunoQuaresma commentedon Apr 22, 2022
Makes sense to have a suspend endpoint and not a delete one. I will make this endpoint and I will let you know. Do you think we should include a "suspended users" view on community, beta, or enterprise?
Adding @tjcran to this conversation since it changes the product a bit.
Emyrk commentedon Apr 23, 2022
The soft delete for other resources made me consider this. But for users you cannot reuse the email, so it makes sense to allow the user to "log in", but it'll say they are suspended. Soft delete feels like we hide the data, where suspension feels like a behavior.
If that makes sense.
@BrunoQuaresma Good tag on Tyler. Good question, we could just keep it in the users view for mvp?
BrunoQuaresma commentedon Apr 23, 2022
@Emyrk do you mean, show active and inactive users as well and maybe have an "active" column?
Emyrk commentedon Apr 24, 2022
@BrunoQuaresma that is what I was thinking yes. Ideally there is a "suspended" page, but probably better to keep the number of pages to a minimum for mvp?
BrunoQuaresma commentedon Apr 25, 2022
@presleyp instead of DELETE a user, we want to "suspend" it. I updated the description to reflect it. Here is the related PR: #1154
presleyp commentedon Apr 25, 2022
@BrunoQuaresma thanks! Will the endpoint to get all users only return un-suspended users? Or will we need to use a query parameter to specify that?
BrunoQuaresma commentedon Apr 25, 2022
Good question, right now it will return all the users. I see two options:
What do you think is best?
presleyp commentedon Apr 26, 2022
@BrunoQuaresma If the backend changed to just return active users, the frontend wouldn't need to change, so unless we need a way to query suspended or all users now, I would just do that.
misskniss commentedon May 6, 2022
@BrunoQuaresma I am reopening this because of the open issues still attached. FYI
[-]User support - CRUD[/-][+]Users - CRUD[/+]BrunoQuaresma commentedon May 6, 2022
@misskniss Ahh I see, I don't think they are CRUD, but I got it.