Skip to content

progress bar: build running is inaccurate  #4676

Closed

Description

@sharkymark

Version: v0.10.2+fbbecf0

The workspace build progress bar is inaccurate in some of my workspaces and tells me any moment now for 10-15 seconds.

I would imagine changing container images, image pull policies, and scaling of Kubernetes nodes making this progress bar inaccurate.

image

Activity

  1. kylecarbs commented on Oct 21, 2022

    @kylecarbs
    Member

    @ammario we need to hide the progress bar unless there are N amount of builds to collect data from. Right now, it shows on the first workspace build.

  2. ammario commented on Oct 21, 2022

    @ammario
    Member

    Even if N is large it can be inaccurate for the reasons Mark describes. Another example is pushing a template update that dramatically affects build time. In that case it could take two weeks for the bar to return to accuracy. This problem was my largest hesitation to building this feature. Some alternatives:

    • We can take the coefficient of variation across the builds, and if it's above a threshold not show a progress bar
    • We can ditch the progress bar and just show an ETA like "1m to 3m remaining..." where "1m" is the 5th percentile and 3m is the 95th percentile
  3. changed the title [-]build running progress bar is inaccurate [/-] [+]progress bar: build running is inaccurate [/+] on Oct 25, 2022
  4. f0ssel commented on Oct 31, 2022

    @f0ssel
    Member

    I think progress is probably best if it's not measured in time because of the reasons you've outlined. Some ideas of things that are relatively static despite the changes you've identified:

    • Static milestones in the job like queued, downloaded, running tf, etc (most basic version)
    • Number of lines of output, the average lines of output should be more stable despite template changes, etc.

    Either way I don' think we need so be accurate here so much as we just need to show them something is moving along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

apiArea: HTTP API

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions