Skip to content

Can we just not display terraform variable names? #4261

Closed as not planned
Closed as not planned

Description

@matifali

Screenshot from 2022-09-15 08-25-41

Can we just somehow do not display this internal terraform variable names var.cpu, var.ram etc
The description is enough to explain what to enter to the user.
It will also resolve #4073 as there is no need for a pretty variable name anymore.

Activity

  1. changed the title [-]Can we just do not display this?[/-] [+]Can we just do not display `terraform` variable names?[/+] on Sep 29, 2022
  2. BrunoQuaresma commented on Sep 29, 2022

    @BrunoQuaresma
    Contributor

    I think the description is not mandatory but we may could display the description as primary and the var name as secondary text. If the description is not provided, the var name gets primary. Sounds good?

  3. kylecarbs commented on Sep 29, 2022

    @kylecarbs
    Member

    We're reworking this flow right now. I'll post some WIP screenshots as it gets further along.

  4. self-assigned this
    on Sep 29, 2022
  5. matifali commented on Sep 29, 2022

    @matifali
    ContributorAuthor

    I think the description is not mandatory but we may could display the description as primary and the var name as secondary text. If the description is not provided, the var name gets primary. Sounds good?

    Yes this sounds good

  6. changed the title [-]Can we just do not display `terraform` variable names?[/-] [+]Can we just not display `terraform` variable names?[/+] on Sep 30, 2022
  7. bpmct commented on Oct 25, 2022

    @bpmct
    Member

    Closing as a duplicate of #4311

  8. matifali commented on Oct 26, 2022

    @matifali
    ContributorAuthor

    Closing as a duplicate of #4311

    Using a coder_parameter is not a simple solution while we already have terraform variables, and they do have a description field. If someone just wants to make the template creation page looks nice without making the actual main.tf too complex. Hiding the variable name is the simplest solution.
    image

  9. matifali commented on Oct 26, 2022

    @matifali
    ContributorAuthor
  10. bpmct commented on Oct 26, 2022

    @bpmct
    Member

    @matifali the current plan is to deprecate variables (and only using them for template-wide settings/CI jobs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

design neededRequest for more beautysiteArea: frontend dashboard

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions