Skip to content

scheduling: auto-stop limit can be bypassed by disabling auto-stop #3630

Closed

Description

@ammario

I can circumvent a template-level Auto-stop limit by disabling auto-stop on my workspace, removing much of the control value of the feature.

Related #3304

Activity

  1. matifali commented on Aug 23, 2022

    @matifali
    Contributor

    I think users should be allowed to increase the autostop time. Otherwise, an admin has too much power, which can cause work and productivity loss for workspace users. What if the admin is not around or not reachable, and they need to increase the time?

  2. ammario commented on Aug 23, 2022

    @ammario
    MemberAuthor

    @matifali the control feature is optional and will just be in our product's enterprise (paid) version. In massive deployments, it's not feasible for admins to track down individuals that are spending too much, so they rely on this kind of end-to-end control.

  3. matifali commented on Aug 23, 2022

    @matifali
    Contributor

    I understand. But it should not be so in OSS version. I am an admin and volunteering to manage our groups servers. So I like to give users as much flexibility as they wish.

  4. github-actions commented on Oct 23, 2022

    @github-actions
    Contributor

    This issue is becoming stale. In order to keep the tracker readable and actionable, I'm going close to this issue in 7 days if there isn't more activity.

  5. ammario commented on Nov 11, 2022

    @ammario
    MemberAuthor

    Reopened as needed by @kconley-sq

  6. bpmct commented on Nov 16, 2022

    @bpmct
    Member

    So we recently changed the "auto-stop limit" to "auto-stop default" which is applied to all workspaces but is overridable by the user. To make this more enforceable, I suggest we do the following:

    Enterprise feature: Add a "Enforce auto stop" checkbox to the template settings page. When checked, this changes the "auto-stop default" to "auto-stop after" in the template settings page. Additionally, users cannot change their auto-stop value or disable auto stop for their individual workspaces.

    If the user keeps a workspace connection open (e.g code-server with websocket or SSH connection), Coder will continue to push the auto-stop time by 1 hour. At this point, we don't want to offer a feature that "kicks" developers out of their workspace, but it's something we may consider down the road.

    If cloud cost is a problem and a lot of workspaces are being "kept alive" despite auto stop settings, workarounds are still possible in this model. For example, an admin would write a bash script/CRON job to stop all workspaces that were started over 72 hours ago.

  7. ammario commented on Nov 16, 2022

    @ammario
    MemberAuthor

    I'm not totally clear on why we changed the "max auto-stop" to default. A developer's incentive is to keep their machine on as long as possible. To me, this advice from the template doesn't seem to provide much value. Why don't we have auto-stop max and also enforce that auto-stop is enabled if its set?

  8. bpmct commented on Nov 22, 2022

    @bpmct
  9. bpmct commented on Dec 5, 2022

    @bpmct
    Member

    @ammario In Coder v1, we had feature requests (and built a feature) to allow users to configure their own auto-stop behavior per workspace. Specifically, this customer wanted to enable data scientists to disable/set an auto-stop value for long-running jobs. However, they wanted to ensure that other workspaces, by default stop at a specific "default" time.

    Screen Shot 2022-12-04 at 4 27 02 PM

    I don't have strong opinions on whether we build this feature as a "default" or a "max," but we will still need to add an option to allow users (or specific groups) to override this behavior. Another option is to use something like @mtojek's proposal for grants: #5106

  10. ammario commented on Dec 5, 2022

    @ammario
    MemberAuthor

    I think grants is a lot of complexity for where we're at today. I think we should just use max (which can also be the default). I think that approach minimizes the number of configuration options.

  11. bpmct commented on Dec 6, 2022

    @bpmct
    Member

    We still need the ability for a user to configure a custom auto-stop duration for their workspace. This was a feature we built for v1 use cases that will migrate to v2.

  12. ammario commented on Dec 7, 2022

    @ammario
    MemberAuthor

    The user can always set an auto-stop duration that is less than the template max.

  13. self-assigned this
    on Jan 16, 2023
  14. removed their assignment
    on Feb 6, 2023
  15. ammario commented on Feb 6, 2023

    @ammario
    MemberAuthor

    This should be a per-template setting.

  16. changed the title [-]Auto-stop limit can be bypassed by disabling auto-stop[/-] [+]scheduling: auto-stop limit can be bypassed by disabling auto-stop[/+] on Feb 6, 2023
  17. added
    s0Major regression, all-hands-on-deck to fix
    s1Bugs that break core workflows. Only humans may set this.
    and removed
    s0Major regression, all-hands-on-deck to fix
    on Feb 9, 2023
  18. deansheather commented on Feb 14, 2023

    @deansheather
    Collaborator

    Closing in favor of #6047, which solves this problem by adding a "max template ttl" control for enterprise customers. This feature will enable template admins to force workspaces to turn off within a certain amount of time, even if the user wants it to stay on for longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

s1Bugs that break core workflows. Only humans may set this.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions