Skip to content

Refactor coder server shutdown procedure and allow TestServer tests to pass goleaks detection #3245

Closed

Description

@mafredri

Currently there are multiple ways in which the Coder server can exit and not all of them go through the same shutdown procedure. There are also cases where an error in one of the steps results skipping some of the shutdown steps.

There are also certain services started where context propagation is not guaranteed to trigger, depending on which error shut down the server.

We should standardize the server shutdown procedure and ensure that all TestServer cases pass goleaks.

Activity

  1. self-assigned this
    on Jul 27, 2022
  2. added a commit that references this issue on Jul 27, 2022
    c6108ec
  3. added a commit that references this issue on Jul 27, 2022
    d27076c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions