Skip to content

bug: token allow-list with a specific template ID returns 500 "column reference \"id\" is ambiguous" #32059

Open

Description

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When testing API-token allow-lists, a token whose allow-list names a specific template (template:<template-uuid>) gets an HTTP 500 from any request that runs the authorized templates query. Workspace creation with the same token succeeds. Reading the workspace back afterwards fails, because building the workspace response loads templates through GetAuthorizedTemplates.

The same token with template:* instead works.

Relevant Log Output

GET /api/v2/workspaces/<workspace-id>
500 {"message":"Internal error fetching workspace resources.","detail":"get templates: pq: column reference \"id\" is ambiguous"}

Expected Behavior

Requests for templates named in the token's allow-list are authorized normally (here, GET /api/v2/workspaces/<workspace-id> returns 200), and templates outside the allow-list are filtered out.

Steps to Reproduce

  1. As an admin, create a regular user <user> with the default Member role in the default organization.
  2. Create a scoped token for that user with a template-specific allow-list:
    coder tokens create --user <user> --lifetime 1d \
      --scope coder:workspaces.create --scope coder:workspaces.access \
      --allow template:<template-uuid> \
      --allow workspace:* \
      --allow organization_member:<user-uuid>
    
  3. With that token, POST /api/v2/users/<user>/workspaces using a version of <template-uuid>. This returns 201.
  4. With that token, GET /api/v2/workspaces/<workspace-id>. This returns the 500 above.
  5. Repeat with --allow template:* instead of --allow template:<template-uuid>. Step 4 then returns 200.

Root cause

TemplateConverter() in coderd/rbac/regosql/configs.go registers resourceIDMatcher(), which emits an unqualified column:

func resourceIDMatcher() sqltypes.VariableMatcher {
	return sqltypes.StringVarMatcher("id :: text", []string{"input", "object", "id"})
}

GetAuthorizedTemplates in coderd/database/modelqueries.go appends the compiled filter to GetTemplatesWithFilter, which joins a second table that also has an id column:

SELECT t.*
FROM template_with_names AS t
LEFT JOIN template_versions tv ON t.active_version_id = tv.id
WHERE ...

The ID predicate is only emitted when the allow-list names a specific template ID. That is why wildcard allow-lists, and tokens without allow-lists, are not affected. The same converter already qualifies the organization column (t.organization_id :: text), so the likely fix is a template-qualified ID matcher in TemplateConverter, such as t.id :: text. A regression test that compiles a non-wildcard template allow-list against this query would cover it.

Workaround

Use --allow template:*. The token can then read and use any template the user's role can already access, so pinning to one template has to be enforced by the client.

Environment

  • Host OS: macOS (arm64), Coder server with built-in PostgreSQL
  • Coder version: v2.38.7. The same code is present in v2.39.1 and on main at 1126533 (resourceIDMatcher and TemplateConverter in coderd/rbac/regosql/configs.go, GetTemplatesWithFilter in coderd/database/queries/templates.sql).

Additional Context

The issue occurs consistently. Possibly related to the broader compiled-SQL audit in #25982, but this is a specific query failure rather than an ACL semantics difference.

Activity

  1. linear-code commented on Nov 11, 2026

    @linear-code
  2. simonepri commented on Nov 13, 2026

    @simonepri

    Hit this too with a narrower token: --scope workspace:read --scope template:read --scope user:read --allow template:<uuid> (plus workspace/user allow entries). Besides GET /api/v2/workspaces/<id>, GET /api/v2/users/me/workspace/<name> fails with the same column reference "id" is ambiguous. template:* works around it for us too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions