Skip to content

Fix error messages in workspaceScheduleXService and workspaceScheduleBannerXService #3097

Closed

Description

@presleyp

Problem

The frontend does not always display the error messages sent from the backend, and even when it does, it does not display the detail that is sometimes sent along with it.

Definition of done

  • There are no uses of displayError in this XService. To replace the error snackbar, render ErrorSummary in the relevant components with the dismissible prop. This way, the user can expand the error detail if desired without the snackbar disappearing too soon.
  • There are no uses of getFormHelpers in the components that consume errors from this XService. Switch to getFormHelpersWithError even if no error. (We will eventually rename it to replace the original getFormHelpers.)
  • The XService always assigns the API error, rather than a hard-coded error message. If a hard-coded error message is needed as a fallback, send it as a prop to ErrorSummary.
  • Errors are only unpacked/transformed in ErrorSummary and getFormHelpersWithError.
  • Storybook has a story for when the error(s) are showing.

Activity

  1. changed the title [-]Fix error messages in workspaceScheduleXService[/-] [+]Fix error messages in workspaceScheduleXService and workspaceScheduleBannerXService[/+] on Jul 25, 2022
  2. self-assigned this
    on Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

siteArea: frontend dashboard

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions