You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Client <> Server version checks should occur in more places #3005
When you run coder version it notifies you of a server <> client version mismatch, but this warning doesn't appear in every command. This led to a slightly confusing situation where a new team member downloaded coder and had a 7.x client with our then 6.5 server. They were getting weird cryptic errors about null fields and such until we thought to check the versions and realized there was a mismatch.
Definition of Done
The version mismatch should be present in every command output except the following subcommands:
Hi @Noah-Huppert, do you happen to know what client your colleague was using? Version checking was added in v0.7.7 and should be checked for every command except coder server and coder gitssh. You should see a warning like this:
Note that it will only emit a warning if the major or minor versions differ. Differing patch versions are expected to be compatible.
This happened on July 13th at 1:30 PM EST, and users had just installed the Coder CLI from the install one-liner in the README. So I think it was probably CLI version https://github.com/coder/coder/releases/tag/v0.7.12 ?
It looks like it's already added to the root command and was already applying to every subcommand except server. It looks like the version check only looks at major.minor and disregards .patch, but also completely disregards version differences if either version is a dev version.
It looks like it's already added to the root command and was already applying to every subcommand except server. It looks like the version check only looks at major.minor and disregards .patch, but also completely disregards version differences if either version is a dev version.
Activity
sreya commentedon Jul 20, 2022
Hi @Noah-Huppert, do you happen to know what client your colleague was using? Version checking was added in v0.7.7 and should be checked for every command except
coder serverandcoder gitssh. You should see a warning like this:Note that it will only emit a warning if the major or minor versions differ. Differing patch versions are expected to be compatible.
Mainstay-Noah-Huppert commentedon Jul 25, 2022
This happened on July 13th at 1:30 PM EST, and users had just installed the Coder CLI from the install one-liner in the README. So I think it was probably CLI version https://github.com/coder/coder/releases/tag/v0.7.12 ?
misskniss commentedon Jul 26, 2022
Whomever grabs this, please add to the definition of done where these mismatch warning would NOT be needed:
etc.
@deansheather suggested adding it to main and checking the sub commands.
deansheather commentedon Jul 28, 2022
It looks like it's already added to the root command and was already applying to every subcommand except
server. It looks like the version check only looks atmajor.minorand disregards.patch, but also completely disregards version differences if either version is a dev version.@Mainstay-Noah-Huppert are you using a dev build of coder on your server?
misskniss commentedon Aug 16, 2022
Note: the August roadmap issue this was originally mentioned in has been closed and moved to a discussion.
deansheather commentedon Aug 17, 2022
@Noah-Huppert did you see my comment above?
catvec commentedon Aug 17, 2022
I don't think I'm using a dev version.
coder versionsays v0.8.1+fd4954b ...`.deansheather commentedon Aug 18, 2022
Can you still reproduce this issue? @Noah-Huppert @Mainstay-Noah-Huppert
kylecarbs commentedon Aug 24, 2022
I believe this is fixed, so I'm closing for now. I'll reopen if you say so @Noah-Huppert !