Skip to content

Client <> Server version checks should occur in more places #3005

Closed

Description

@catvec

Problem

When you run coder version it notifies you of a server <> client version mismatch, but this warning doesn't appear in every command. This led to a slightly confusing situation where a new team member downloaded coder and had a 7.x client with our then 6.5 server. They were getting weird cryptic errors about null fields and such until we thought to check the versions and realized there was a mismatch.

Definition of Done

The version mismatch should be present in every command output except the following subcommands:

  • gitssh
  • ssh
  • server

Activity

  1. sreya commented on Jul 20, 2022

    @sreya
    Collaborator

    Hi @Noah-Huppert, do you happen to know what client your colleague was using? Version checking was added in v0.7.7 and should be checked for every command except coder server and coder gitssh. You should see a warning like this:

    image

    Note that it will only emit a warning if the major or minor versions differ. Differing patch versions are expected to be compatible.

  2. Mainstay-Noah-Huppert commented on Jul 25, 2022

    @Mainstay-Noah-Huppert
    Contributor

    This happened on July 13th at 1:30 PM EST, and users had just installed the Coder CLI from the install one-liner in the README. So I think it was probably CLI version https://github.com/coder/coder/releases/tag/v0.7.12 ?

  3. misskniss commented on Jul 26, 2022

    @misskniss

    Whomever grabs this, please add to the definition of done where these mismatch warning would NOT be needed:

    • server
    • port forward sub command
    • ssh command
      etc.

    @deansheather suggested adding it to main and checking the sub commands.

  4. deansheather commented on Jul 28, 2022

    @deansheather
    Collaborator

    It looks like it's already added to the root command and was already applying to every subcommand except server. It looks like the version check only looks at major.minor and disregards .patch, but also completely disregards version differences if either version is a dev version.

    @Mainstay-Noah-Huppert are you using a dev build of coder on your server?

  5. misskniss commented on Aug 16, 2022

    @misskniss

    Note: the August roadmap issue this was originally mentioned in has been closed and moved to a discussion.

  6. deansheather commented on Aug 17, 2022

    @deansheather
    Collaborator

    @Noah-Huppert did you see my comment above?

  7. catvec commented on Aug 17, 2022

    @catvec
    Author

    It looks like it's already added to the root command and was already applying to every subcommand except server. It looks like the version check only looks at major.minor and disregards .patch, but also completely disregards version differences if either version is a dev version.

    @Mainstay-Noah-Huppert are you using a dev build of coder on your server?

    I don't think I'm using a dev version. coder version says v0.8.1+fd4954b ...`.

  8. deansheather commented on Aug 18, 2022

    @deansheather
    Collaborator

    Can you still reproduce this issue? @Noah-Huppert @Mainstay-Noah-Huppert

  9. kylecarbs commented on Aug 24, 2022

    @kylecarbs
    Member

    I believe this is fixed, so I'm closing for now. I'll reopen if you say so @Noah-Huppert !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

waiting-for-infoThe issue creator is asked to provide more information.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions