You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
I'm unable to only set an auto-off while leaving on to manual #2792
I'd like to change the auto-off time for my workspace to 8 hours instead of the default of 12, but I can't seem to be able to without also enabling auto-on.
@spikecurtis this is intended behavior (I think). If you specify a start time (in the above screenshot, the start time is 9:30am), you must select at least one day of the week. This is dictated by the BE:
And we've designed intentionally around this constraint on the FE and added tests for it. If you clear the start time field, you can successfully submit the form without any days selected.
I think what we should do here is amend the validation message so it says something like "Must set at least one day of the week if start time is set" and I can submit a PR for that.
But, it seems to me that the same lack of clarity/precision around the error message for days applies equally to the start time. It currently says, unqualified, "Start time is required" when really, "Start time is required if any days are selected"
Good catch! How about we change that string to Start time is required when days of the week are selected? I'm going to tag you in the PR I'm making and you can tweak the language if you like.
Fine to tag me, but that language sounds ok. Note I opened a new issue: #3051 with some more minor annoyances and suggestions. I'm not claiming this is high priority!
Activity
johnstcn commentedon Jul 1, 2022
@spikecurtis is this a duplicate of #2030 ?
spikecurtis commentedon Jul 2, 2022
Kira-Pilot commentedon Jul 19, 2022
@spikecurtis this is intended behavior (I think). If you specify a start time (in the above screenshot, the start time is 9:30am), you must select at least one day of the week. This is dictated by the BE:

And we've designed intentionally around this constraint on the FE and added tests for it. If you clear the start time field, you can successfully submit the form without any days selected.
I think what we should do here is amend the validation message so it says something like "Must set at least one day of the week if start time is set" and I can submit a PR for that.
feat: amend schedule form valiidation string
feat: amend schedule form valiidation string (#3043)
spikecurtis commentedon Jul 19, 2022
#3043 is definitely an improvement!
But, it seems to me that the same lack of clarity/precision around the error message for days applies equally to the start time. It currently says, unqualified, "Start time is required" when really, "Start time is required if any days are selected"
Kira-Pilot commentedon Jul 19, 2022
Good catch! How about we change that string to
Start time is required when days of the week are selected? I'm going to tag you in the PR I'm making and you can tweak the language if you like.spikecurtis commentedon Jul 19, 2022
Fine to tag me, but that language sounds ok. Note I opened a new issue: #3051 with some more minor annoyances and suggestions. I'm not claiming this is high priority!
clarify start validation in schedule
clarify start validation in schedule (#3052)