Skip to content

I'm unable to only set an auto-off while leaving on to manual #2792

Description

@spikecurtis

Workspace schedule manual

I'd like to change the auto-off time for my workspace to 8 hours instead of the default of 12, but I can't seem to be able to without also enabling auto-on.

Activity

  1. johnstcn commented on Jul 1, 2022

    @johnstcn
    Member

    @spikecurtis is this a duplicate of #2030 ?

  2. spikecurtis commented on Jul 2, 2022

    @spikecurtis
    CollaboratorAuthor
  3. self-assigned this
    on Jul 18, 2022
  4. Kira-Pilot commented on Jul 19, 2022

    @Kira-Pilot
    Contributor

    @spikecurtis this is intended behavior (I think). If you specify a start time (in the above screenshot, the start time is 9:30am), you must select at least one day of the week. This is dictated by the BE:
    Screen Shot 2022-07-19 at 11 29 31 AM

    And we've designed intentionally around this constraint on the FE and added tests for it. If you clear the start time field, you can successfully submit the form without any days selected.

    I think what we should do here is amend the validation message so it says something like "Must set at least one day of the week if start time is set" and I can submit a PR for that.

  5. added a commit that references this issue on Jul 19, 2022
    f19019d
  6. added a commit that references this issue on Jul 19, 2022
    1830a18
  7. spikecurtis commented on Jul 19, 2022

    @spikecurtis
    CollaboratorAuthor

    #3043 is definitely an improvement!

    But, it seems to me that the same lack of clarity/precision around the error message for days applies equally to the start time. It currently says, unqualified, "Start time is required" when really, "Start time is required if any days are selected"

  8. Kira-Pilot commented on Jul 19, 2022

    @Kira-Pilot
    Contributor

    Good catch! How about we change that string to Start time is required when days of the week are selected? I'm going to tag you in the PR I'm making and you can tweak the language if you like.

  9. spikecurtis commented on Jul 19, 2022

    @spikecurtis
    CollaboratorAuthor

    Fine to tag me, but that language sounds ok. Note I opened a new issue: #3051 with some more minor annoyances and suggestions. I'm not claiming this is high priority!

  10. added 2 commits that reference this issue on Jul 19, 2022
    017ad75
    0c18a23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

siteArea: frontend dashboard

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions