Skip to content

/bin/ route should return an actual 404 error if the binary doesn't exist #2510

Closed

Description

@deansheather

If you hit /bin/asdf on a deployment, you get a 200 OK response with the index.html of the SPA. The frontend correctly renders a 404 page, but curl takes this as a success and the startup script continues onwards.

Any "not found" errors under /bin/ should return a 400 Not Found response with a response message instead of index.html.

Activity

  1. kylecarbs commented on Aug 24, 2022

    @kylecarbs
    Member

    Seems like this happens now! Our logic must have changed 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions