Skip to content

Make created_by field in templates table not null #2283

Closed

Description

@AbhineetJain

#2228 added a created_by field to the Templates table to track the user that created the template. This field was kept nullable since it was not clear how to populate the field in existing records. @kylecarbs suggested that we make the created_by field not nullable and default to the first-created user instead, otherwise it just very odd design for the data model.

Activity

  1. self-assigned this
    on Jun 13, 2022
  2. kylecarbs commented on Jun 13, 2022

    @kylecarbs
    Member

    @AbhineetJain what do you think about this being maintained_by instead? It seems odd to have this be a static field.

  3. AbhineetJain commented on Jun 13, 2022

    @AbhineetJain
    ContributorAuthor

    I wonder if there's a case for both pieces of information to be maintained. maintained_by does come with the overhead of allowing someone in the org to update that field, who could do it etc.

  4. kylecarbs commented on Jun 13, 2022

    @kylecarbs
    Member

    I think it'd be helpful to understand the maintainer.

    If someone gets promoted or leaves a company and is no longer the maintainer, we'd hate for them to display as the contact in created_by.

  5. AbhineetJain commented on Jun 13, 2022

    @AbhineetJain
    ContributorAuthor

    Makes sense. We can update the field name, but I am guessing the functionality also changes? Like the user would probably want to specify the maintainer when creating the template (we can default to the creator), and have an option to update the maintainer (for some restricted roles).

  6. added this to the Community MVP milestone on Jun 13, 2022
  7. kylecarbs commented on Jun 13, 2022

    @kylecarbs
    Member

    Makes sense to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

apiArea: HTTP API

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions