You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Make created_by field in templates table not null #2283
#2228 added a created_by field to the Templates table to track the user that created the template. This field was kept nullable since it was not clear how to populate the field in existing records. @kylecarbs suggested that we make the created_by field not nullable and default to the first-created user instead, otherwise it just very odd design for the data model.
I wonder if there's a case for both pieces of information to be maintained. maintained_by does come with the overhead of allowing someone in the org to update that field, who could do it etc.
Makes sense. We can update the field name, but I am guessing the functionality also changes? Like the user would probably want to specify the maintainer when creating the template (we can default to the creator), and have an option to update the maintainer (for some restricted roles).
Activity
kylecarbs commentedon Jun 13, 2022
@AbhineetJain what do you think about this being
maintained_byinstead? It seems odd to have this be a static field.AbhineetJain commentedon Jun 13, 2022
I wonder if there's a case for both pieces of information to be maintained.
maintained_bydoes come with the overhead of allowing someone in the org to update that field, who could do it etc.kylecarbs commentedon Jun 13, 2022
I think it'd be helpful to understand the maintainer.
If someone gets promoted or leaves a company and is no longer the maintainer, we'd hate for them to display as the contact in created_by.
AbhineetJain commentedon Jun 13, 2022
Makes sense. We can update the field name, but I am guessing the functionality also changes? Like the user would probably want to specify the maintainer when creating the template (we can default to the creator), and have an option to update the maintainer (for some restricted roles).
kylecarbs commentedon Jun 13, 2022
Makes sense to me!