Skip to content

Add support for emojis on templates #2262

Closed

Description

@ammario

Acceptance criteria

The template admin can configure emojis to accompany their template as a part of the main.tf.

Schema TBD.

image

Wouldn't this be beautiful?

(idea cred @kylecarbs)

Activity

  1. Explosion-Scratch commented on Jun 10, 2022

    @Explosion-Scratch

    Yea but with twemoji

  2. ammario commented on Jun 10, 2022

    @ammario
    MemberAuthor

    @Explosion-Scratch nice idea! We're looking into it.

  3. sharkymark commented on Jun 11, 2022

    @sharkymark
    Contributor

    👽

  4. Explosion-Scratch commented on Jun 11, 2022

    @Explosion-Scratch

    @Explosion-Scratch nice idea! We're looking into it.

    It wasn't my idea lol, it was @kylecarbs apparently

  5. ketang commented on Jun 11, 2022

    @ketang
    Contributor

    This is a silly thing that is also good to have.

    We can do emoji in the names already, right? This would be a dedicated field for selecting one icon?

  6. ketang commented on Jun 11, 2022

    @ketang
    Contributor

    Seems like we should do this for users and workspaces too. None of this needs to happen immediately, but if easy...

  7. kylecarbs commented on Jun 11, 2022

    @kylecarbs
    Member

    I think we add an icon column that is a URI. For now it can be emoji://handwave, but eventually it can be file:/// etc.

  8. ketang commented on Jun 11, 2022

    @ketang
    Contributor

    Is emoji://handwave a real thing, or did you just invent it?

    We don't want to allow file:// ever. If you're referring to an icon embedded in the archive, then we should go another way, for instance requiring them to have a file icon.json or something.

  9. Explosion-Scratch commented on Jun 11, 2022

    @Explosion-Scratch

    yeah, not exactly sure why to use emoji://, wouldn't just using a lookup table and allowing users to choose be fine? Emojis.json was made for this purpose (find on GH)

  10. ketang commented on Jun 11, 2022

    @ketang
    Contributor

    I actually thought emoji:// was pretty clever. We could forge a new path! Modifiers and combinations like skin tone would be interesting though.

  11. Explosion-Scratch commented on Jun 11, 2022

    @Explosion-Scratch

    I actually thought emoji:// was pretty clever. We could forge a new path! Modifiers and combinations like skin tone would be interesting though.

    "forging a new path" was what you did in 1990. Now it'd just be inefficient, hard to implement, never used by anyone else, and probably insecure

  12. ammario commented on Jun 12, 2022

    @ammario
    MemberAuthor

    This is a silly thing that is also good to have.

    We can do emoji in the names already, right? This would be a dedicated field for selecting one icon?

    The big problem with emojis in the name as opposed to a separate field is it makes it far harder to work with names in the CLI and programmatically.

  13. misskniss commented on Aug 2, 2022

    @misskniss

    @kylecarbs are you up for owning this?

  14. kylecarbs commented on Aug 2, 2022

    @kylecarbs
    Member

    Sure!

  15. self-assigned this
    on Aug 2, 2022
  16. ketang commented on Aug 2, 2022

    @ketang
    Contributor

    While emoji:// would be a neat gimmick, data URIs should be just fine:
    data:text/plain;charset=utf-8;base64,8J+MrvCfpog=

    Should be read as

    🌮🦈

  17. ammario commented on Aug 2, 2022

    @ammario
    MemberAuthor

    Can we do #2221 instead of this? #2221 would still allow emojis, but the more reasonable use case is using OS/Cloud/Software logos as described in that issue.

  18. kylecarbs commented on Aug 2, 2022

    @kylecarbs
    Member

    Makes sense to me. I'll swap it out.

  19. sharkymark commented on Aug 2, 2022

    @sharkymark
    Contributor

    😞

  20. BrunoQuaresma commented on Aug 19, 2022

    @BrunoQuaresma
    Contributor

    Reopening this, since icons can support emojis if users pass the image path, we want to provide a better experience by adding an emoji picker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

apiArea: HTTP APIsiteArea: frontend dashboard

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions