Skip to content

Unnest template/examples #2031

Closed as not planned
Closed as not planned

Description

@ammario

There's no point?

Activity

  1. added this to the Community MVP milestone on Jun 3, 2022
  2. dwahler commented on Jun 10, 2022

    @dwahler
    Contributor

    The reason for these being nested is so that we can embed the entire examples/templates directory, including subdirectories (see #1669), without also including the source code of the examples Go package itself. As far as I can see, the embed package doesn't provide a way to recursively embed a directory while also excluding a configurable subset of files.

    I figured the inelegance of an extra level in the directory hierarchy was better than the inelegance of bundling files that never get used, but YMMV.

    Removing this nesting would require filtering out non-directories in examples.List instead, and also reverting the documentation changes that were made in #1715.

  3. kylecarbs commented on Jun 12, 2022

    @kylecarbs
    Member

    @dwahler would embed ./*/* include the source code itself?

    The user experience is a bit odd with the nesting because it appears that examples is just a package. Having these at an upper-level fixes it I think.

  4. removed this from the Community MVP milestone on Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions