Skip to content

Entering minutes field in workspace schedule start time triggers day of week validation failure #2030

Closed

Description

@ketang

OS Information

Mac OS X
Chrome Version 101.0.4951.64 (Official Build) (arm64)
Coder v0.0.0-devel+d6e9eab

Steps to Reproduce

  1. From a workspace page, click Edit Schedule
  2. Click the "start time" field to give it focus
  3. Type a value for hours, e.g. 10
  4. Type a value for minutes, e.g 3

Expected

Days of week stay chill; I'll get to you.

Actual

Happy
Screen Shot 2022-06-03 at 16 52 45

One 3 later: sad.
Screen Shot 2022-06-03 at 16 52 53

Activity

  1. greyscaled commented on Jun 3, 2022

    @greyscaled
    Contributor

    I do not think this is a bug.

  2. ketang commented on Jun 3, 2022

    @ketang
    ContributorAuthor

    Why not? I shouldn't be chastised for not selecting days of the week if I haven't gotten to that part of the form.

    Also, even if that were the case, why wouldn't it be in that error state from the start? Why does it happen when I go from just hours to hours and minutes?

  3. greyscaled commented on Jun 6, 2022

    @greyscaled
    Contributor

    I misunderstood, it's that the validation is happening before it's touched. I will change this back over to a bug.

  4. changed the title [-]Bug: entering minutes field in workspace schedule start time triggers day of week validation failure[/-] [+]Entering minutes field in workspace schedule start time triggers day of week validation failure[/+] on Jun 7, 2022
  5. added this to the Community MVP milestone on Jun 14, 2022
  6. johnstcn commented on Jun 14, 2022

    @johnstcn
    Member
  7. self-assigned this
    on Jun 22, 2022
  8. johnstcn commented on Jul 21, 2022

    @johnstcn
    Member

    I'm no longer able to reproduce this issue. Opening the schedule and un-checking/deleting everything, and then just entering '1' in the 'hours' field no longer triggers a validation error. Entering both hours and minutes then triggers the day-of-week validation, which is required if you set the minute and hour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

siteArea: frontend dashboard

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions