You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat: do not show sensitive values in terminal #1903
Change examples to ask users to specify a .tfvars file, or use the cloud the host machine may already be authenticated with (e.g kubectx, aws session).
Why do you want this feature?
Remove secrets from being entered in shell or screen recordings
Are there any workarounds to get this functionality today?
A user can edit the template or specify params this #1541
changed the title [-]example: do not prompt users for cloud secrets via terminal [/-][+]example: do not show sensitive values in terminal [/+]on May 30, 2022
What do you think about explaining in coder templates init that it's very expected for users to modify the templates? I feel that this isn't obvious enough, and users get errors that they could easily fix, but aren't sure if it's a bug in Coder or not.
are something only they can fix, and we can't make templates that work for all cloud scenarios, since all clouds are unique! Because of this, we should educate the user that they might need to modify the templates, and that's entirely expected. We have a warning right now, but it should probably be louder.
What do you think about explaining in coder templates init that it's very expected for users to modify the templates? I feel that this isn't obvious enough, and users get errors that they could easily fix, but aren't sure if it's a bug in Coder or not.
I agree, and this certainly would help so that admins can modify the template to comply with their policies. What do you think about also adding some way for sensitive variables (e.g an API key) to be masked when inputted via the CLI. I guess a user could always specify vars from a file though.
Terraform displays the value in plaintext in the terminal, so I think it's fine for us to do it too. Our problem is less that we display the secrets, and more how the secrets are specified.
We shouldn't break the Terraform paradigm of authenticating at a system level, and I think it's simpler for users to understand the typical Terraform auth patterns (eg. not passing a secret via variable).
Activity
[-]example: do not prompt users for cloud secrets via terminal [/-][+]example: do not show sensitive values in terminal [/+]kylecarbs commentedon May 30, 2022
What do you think about explaining in
coder templates initthat it's very expected for users to modify the templates? I feel that this isn't obvious enough, and users get errors that they could easily fix, but aren't sure if it's a bug in Coder or not.ketang commentedon May 30, 2022
By "users" here this means admins and owners, right?
If they're getting errors, though, we need to fix them.
kylecarbs commentedon May 30, 2022
Errors like:
are something only they can fix, and we can't make templates that work for all cloud scenarios, since all clouds are unique! Because of this, we should educate the user that they might need to modify the templates, and that's entirely expected. We have a warning right now, but it should probably be louder.
ketang commentedon May 30, 2022
Aaah got it.
[-]example: do not show sensitive values in terminal [/-][+]feat: do not show sensitive values in terminal [/+]bpmct commentedon May 31, 2022
I agree, and this certainly would help so that admins can modify the template to comply with their policies. What do you think about also adding some way for sensitive variables (e.g an API key) to be masked when inputted via the CLI. I guess a user could always specify vars from a file though.
kylecarbs commentedon May 31, 2022
Terraform displays the value in plaintext in the terminal, so I think it's fine for us to do it too. Our problem is less that we display the secrets, and more how the secrets are specified.
We shouldn't break the Terraform paradigm of authenticating at a system level, and I think it's simpler for users to understand the typical Terraform auth patterns (eg. not passing a secret via variable).
bpmct commentedon May 31, 2022
Will close this and re-open one related to clarifying that users can / are expected to edit templates.