Skip to content

feat: do not show sensitive values in terminal  #1903

Closed

Description

@bpmct

What is your suggestion?

Change examples to ask users to specify a .tfvars file, or use the cloud the host machine may already be authenticated with (e.g kubectx, aws session).

Why do you want this feature?

Remove secrets from being entered in shell or screen recordings

Are there any workarounds to get this functionality today?

A user can edit the template or specify params this #1541

Are you interested in submitting a PR for this?

Yes

Activity

  1. self-assigned this
    on May 30, 2022
  2. changed the title [-]example: do not prompt users for cloud secrets via terminal [/-] [+]example: do not show sensitive values in terminal [/+] on May 30, 2022
  3. kylecarbs commented on May 30, 2022

    @kylecarbs
    Member

    What do you think about explaining in coder templates init that it's very expected for users to modify the templates? I feel that this isn't obvious enough, and users get errors that they could easily fix, but aren't sure if it's a bug in Coder or not.

  4. ketang commented on May 30, 2022

    @ketang
    Contributor

    By "users" here this means admins and owners, right?

    If they're getting errors, though, we need to fix them.

  5. kylecarbs commented on May 30, 2022

    @kylecarbs
    Member

    Errors like:

    You don't have a default VPC subnet.
    

    are something only they can fix, and we can't make templates that work for all cloud scenarios, since all clouds are unique! Because of this, we should educate the user that they might need to modify the templates, and that's entirely expected. We have a warning right now, but it should probably be louder.

  6. ketang commented on May 30, 2022

    @ketang
    Contributor

    Aaah got it.

  7. changed the title [-]example: do not show sensitive values in terminal [/-] [+]feat: do not show sensitive values in terminal [/+] on May 31, 2022
  8. bpmct commented on May 31, 2022

    @bpmct
    MemberAuthor

    What do you think about explaining in coder templates init that it's very expected for users to modify the templates? I feel that this isn't obvious enough, and users get errors that they could easily fix, but aren't sure if it's a bug in Coder or not.

    I agree, and this certainly would help so that admins can modify the template to comply with their policies. What do you think about also adding some way for sensitive variables (e.g an API key) to be masked when inputted via the CLI. I guess a user could always specify vars from a file though.

  9. kylecarbs commented on May 31, 2022

    @kylecarbs
    Member

    Terraform displays the value in plaintext in the terminal, so I think it's fine for us to do it too. Our problem is less that we display the secrets, and more how the secrets are specified.

    We shouldn't break the Terraform paradigm of authenticating at a system level, and I think it's simpler for users to understand the typical Terraform auth patterns (eg. not passing a secret via variable).

  10. bpmct commented on May 31, 2022

    @bpmct
    MemberAuthor

    Will close this and re-open one related to clarifying that users can / are expected to edit templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions