You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
All org users should have access to the user list for their own org in the UI #1746
As an org member, I want the ability to navigate to the users page in the UI so that I can see all the other users in my org.
Right now, a non-admin member of an org would have to manaully enter the URL for the users page since the current link that page is in the Admin menu that will not be visible to non-admin roles. So we need a button or menu list item somewhere for non-admins to get to this page.
In this image, my role was Member only and I could only get to this page by manually entering the URL without the admin dropdown.
Implementation Details:
Move the Users list to the Top Nav to the right of the Templates link
Non-Admin users will see all other users in their org but will only have read access to users and each users role
Admins will have all the usual permissions to read/update/delete/change password for users in the list
@BrunoQuaresma This is the issue where we should decide as a team where the best place in the UI would be to put a link to this page for our non-admins.
CC @tjcran
Hmm... it should be done in the FE. Probably the BE is not allowing a member user to read all the users. I think it is probably a role issue on RBAC cc: @Emyrk. It is being checked here:
Ahh, no backend issue. The admin dropdown is displayed if the user has that permission to update users. What makes sense... what we probably want to do is to move the "Users" nav to the main navbar and check the readUsers permission as we do here:
@misskniss there is only 1 organization for MVP. So isn't the admin page the same page for all users? Like the actual page is the exact same for both types of user. (member and admin)
The solution agreed upon is that we will be removing the Admin dropdown from the topnav and move the "Users" menu to the topnav next to templates. The Users page will be the same for both admins and non-admins, but only admins will be able to "do stuff" via the RBAC, which is already in place anyway.
Activity
misskniss commentedon May 25, 2022
@BrunoQuaresma This is the issue where we should decide as a team where the best place in the UI would be to put a link to this page for our non-admins.
CC @tjcran
BrunoQuaresma commentedon May 25, 2022
Hmm... it should be done in the FE. Probably the BE is not allowing a member user to read all the users. I think it is probably a role issue on RBAC cc: @Emyrk. It is being checked here:
coder/site/src/xServices/auth/authXService.ts
Lines 18 to 24 in 3f770e1
BrunoQuaresma commentedon May 25, 2022
Ahh, no backend issue. The admin dropdown is displayed if the user has that permission to update users. What makes sense... what we probably want to do is to move the "Users" nav to the main navbar and check the readUsers permission as we do here:
coder/site/src/components/Navbar/Navbar.tsx
Lines 11 to 14 in 3f770e1
Emyrk commentedon May 25, 2022
@misskniss there is only 1 organization for MVP. So isn't the admin page the same page for all users? Like the actual page is the exact same for both types of user. (member and admin)
ketang commentedon May 25, 2022
I question whether this is a switch blocker.
tjcran commentedon May 25, 2022
The solution agreed upon is that we will be removing the Admin dropdown from the topnav and move the "Users" menu to the topnav next to templates. The Users page will be the same for both admins and non-admins, but only admins will be able to "do stuff" via the RBAC, which is already in place anyway.
chore: add users link to nav bar
chore: add users link to nav bar (#1797)