Skip to content

All org users should have access to the user list for their own org in the UI #1746

Closed

Description

@misskniss

As an org member, I want the ability to navigate to the users page in the UI so that I can see all the other users in my org.


Right now, a non-admin member of an org would have to manaully enter the URL for the users page since the current link that page is in the Admin menu that will not be visible to non-admin roles. So we need a button or menu list item somewhere for non-admins to get to this page.

In this image, my role was Member only and I could only get to this page by manually entering the URL without the admin dropdown.

Non-Admin user page view.png


Implementation Details:

  • Move the Users list to the Top Nav to the right of the Templates link
  • Non-Admin users will see all other users in their org but will only have read access to users and each users role
  • Admins will have all the usual permissions to read/update/delete/change password for users in the list

(This is related to issue #1742 as well. )

Activity

  1. added this to the Community MVP milestone on May 25, 2022
  2. misskniss commented on May 25, 2022

    @misskniss
    Author

    @BrunoQuaresma This is the issue where we should decide as a team where the best place in the UI would be to put a link to this page for our non-admins.
    CC @tjcran

  3. BrunoQuaresma commented on May 25, 2022

    @BrunoQuaresma
    Contributor

    Hmm... it should be done in the FE. Probably the BE is not allowing a member user to read all the users. I think it is probably a role issue on RBAC cc: @Emyrk. It is being checked here:

    export const permissionsToCheck = {
    [checks.readAllUsers]: {
    object: {
    resource_type: "user",
    },
    action: "read",
    },

  4. BrunoQuaresma commented on May 25, 2022

    @BrunoQuaresma
    Contributor

    Ahh, no backend issue. The admin dropdown is displayed if the user has that permission to update users. What makes sense... what we probably want to do is to move the "Users" nav to the main navbar and check the readUsers permission as we do here:

    const permissions = useSelector(xServices.authXService, selectPermissions)
    // When we have more options in the admin dropdown we may want to check this
    // for more permissions
    const displayAdminDropdown = !!permissions?.updateUsers

  5. Emyrk commented on May 25, 2022

    @Emyrk
    Member

    @misskniss there is only 1 organization for MVP. So isn't the admin page the same page for all users? Like the actual page is the exact same for both types of user. (member and admin)

  6. ketang commented on May 25, 2022

    @ketang
    Contributor

    I question whether this is a switch blocker.

  7. tjcran commented on May 25, 2022

    @tjcran

    The solution agreed upon is that we will be removing the Admin dropdown from the topnav and move the "Users" menu to the topnav next to templates. The Users page will be the same for both admins and non-admins, but only admins will be able to "do stuff" via the RBAC, which is already in place anyway.

  8. self-assigned this
    on May 25, 2022
  9. added a commit that references this issue on May 26, 2022
    8c64457
  10. added a commit that references this issue on May 26, 2022
    b4c41d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

siteArea: frontend dashboard

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions