Skip to content

Bug: subfolders in example templates are not bundled #1669

Closed

Description

@bpmct

OS Information

  • OS: Debian 11

  • Browser (if applicable): N/A

  • Architecture: AMD64

  • coder --version:

    root@coder-v2:~/coder-config/templates/docker-image-builds# coder --version
    Coder v0.5.11-devel+a8a8f9db Fri May 20 23:39:51 UTC 2022
    https://github.com/coder/coder/commit/a8a8f9dbf30cbbdfe604d00f56870086d7316d4c

Steps to Reproduce

Install steps

  1. Create a release from main branch: goreleaser release --rm-dist --snapshot
  2. Run/install Coder from the built dist/ artifacts (--dev flag will do)

Repro steps

  1. coder templates init
  2. Select Develop in Docker with custom image builds
  3. Try to cd to ./docker-image-builds/images. The folder is missing. This breaks the template.

Expected

Subfolder contents are bundled, such as ./examples/docker-image-builds/images/

Actual

The ./docker-image-builds/images folder is missing when you clone from coder templates init

Notes

Users can workaround this and use the example template by cloning the repo directly. The images/ subdirectory is bundled correctly in the deployment

git clone git@github.com:coder/coder.git
cd ./coder/examples/docker-image-builds
coder templates create

Activity

  1. changed the title [-]Bug: subfolders in templates from `examples/` are not bundled in release[/-] [+]Bug: subfolders in example templates are not bundled in release[/+] on May 23, 2022
  2. bpmct commented on May 23, 2022

    @bpmct
    MemberAuthor

    I added switch blocker, but could remove if we decide it's better just to remove this Docker template.

  3. changed the title [-]Bug: subfolders in example templates are not bundled in release[/-] [+]Bug: subfolders in example templates are not bundled[/+] on May 23, 2022
  4. ketang commented on May 23, 2022

    @ketang
    Contributor

    I agree this is a blocker, partly premised on the assumption that it's a really small fix.

  5. added this to the Community MVP milestone on May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

apiArea: HTTP API

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions