You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Warn users if their access URL is localhost or 127.0.0.1 #1528
When coder server or coder templates create is run (unsure which is best), I suggest displaying an error:
⚠️ Coder's access URL is set to 127.0.0.1 or localhost. Resources provisioned are unlikely to work with Coder.
Please consider changing your `coder server` access URL, or specifying unique access URLs on
templates.
For more information, see: https://github.com/coder/coder/issues/1528
I was chatting with @kylecarbs about this on Discord:
I think the product should block the creation of workspaces when it wouldn't be accessible externally, yup!
Why do you want this feature?
When workspaces are created, the Coder agent on the workspace needs to dial the Coder access URL. If the access url is a loopback address, then the workspace would end up dialing itself instead of the control plane.
Resources will just start and hang on Waiting for connection from dev.
Are there any workarounds to get this functionality today?
Each example template we provide could include a warning. Templates only leverage resources on the host (e.g docker) can also override the access URL, as done for the docker template in #1507. However, no public cloud templates would work unless Coder is exposed.
Somewhat related: #1176 would allow users to tunnel within Coder itself without the need to use up ngrok, Caddy, or another service to publish and secure a Coder access URL. However, it's a complex undertaking.
changed the title [-]Feat: warn users if their access URL is localhost or 127.0.0.1[/-][+]Warn users if their access URL is localhost or 127.0.0.1[/+]on Jun 7, 2022
I implemented this as a warning, rather than an error, because we don't know with certainty that a localhost access URL is an invalid configuration.
For one thing -- as the message points out -- even if the default access URL uses a loopback address, individual templates could override it. That's what our example Docker template does (replacing localhost with host.docker.internal), and making this an error would break it.
Activity
greyscaled commentedon May 18, 2022
This seems like a ticket that should be complete for the CE milestone.
Nice details @bpmct !
misskniss commentedon May 19, 2022
Adding this to community in case Lucy gets free time to work on it. It may need to be brought in later depending on load.
[-]Feat: warn users if their access URL is localhost or 127.0.0.1[/-][+]Warn users if their access URL is localhost or 127.0.0.1[/+]dwahler commentedon Jun 10, 2022
I implemented this as a warning, rather than an error, because we don't know with certainty that a localhost access URL is an invalid configuration.
For one thing -- as the message points out -- even if the default access URL uses a loopback address, individual templates could override it. That's what our example Docker template does (replacing
localhostwithhost.docker.internal), and making this an error would break it.bpmct commentedon Jun 10, 2022
Agreed. I think a warning is definitely preferable here.
bpmct commentedon Jun 10, 2022
Ah, I just noticed I used the word "error" in the description but "warning" in the title. I'll look out for that.