You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It was one of my onboarding tasks (#1112). There was discussion among the team replace it with something like all-contributors instead.
I'd be in favor of just relying on the builtin GitHub Contributors, but unfortunately it only picks up commits to main, so we can't give thanks to people who've contributed in other ways. For example issue triage or assists/reviews on PRs.
Whatever form it may take, it would be nice to keep the contributors in the readme for as long as feasible to make it more prominent/show our appreciation. We may have to move it to a separate file at some point, but that would feel a bit like hiding it.
I don't think this is my place(my suggestion though), but why not add the contributors list as a mini-table, like an Excel sheet? Less space, more contributors, and maybe also enclose it with a collapsible section, if it seems to take more screen space.
Activity
ammario commentedon May 13, 2022
Actually, I propose we delete the contributor list. It's built into GitHub already.
mafredri commentedon May 13, 2022
It was one of my onboarding tasks (#1112). There was discussion among the team replace it with something like all-contributors instead.
I'd be in favor of just relying on the builtin GitHub Contributors, but unfortunately it only picks up commits to
main, so we can't give thanks to people who've contributed in other ways. For example issue triage or assists/reviews on PRs.Whatever form it may take, it would be nice to keep the contributors in the readme for as long as feasible to make it more prominent/show our appreciation. We may have to move it to a separate file at some point, but that would feel a bit like hiding it.
ammario commentedon May 13, 2022
I disagree on the basis it is non-standard, unlikely to be up to date, and bloats the README.
kylecarbs commentedon May 16, 2022
@AbhineetJain thoughts on the discussion here? Seems like we could just remove it!
AbhineetJain commentedon May 16, 2022
@kylecarbs I interpreted the discussion as removing the list from the README, and instead maintaining the standard
CONTRIBUTORS.md.AbhineetJain commentedon May 16, 2022
I agree though, that it is unlikely to be up-to-date in the long run.
Emyrk commentedon May 16, 2022
Is there any bots we can use to maintain it?
AbhineetJain commentedon May 16, 2022
As @mafredri mentioned above, there is all-contributors.
ammario commentedon May 18, 2022
👍 to automating it with an existing bot and using a separate file. Let's make the README as clean as a temple.
im-coder-lg commentedon May 19, 2022
I don't think this is my place(my suggestion though), but why not add the contributors list as a mini-table, like an Excel sheet? Less space, more contributors, and maybe also enclose it with a collapsible section, if it seems to take more screen space.