Skip to content

Extract helper function for creating a new workspace build #1401

Closed as not planned

Description

@johnstcn

In the referenced issue, we have duplicated logic to fetch the previous workspace build and provisioner job and insert another provisioner job / workspace build using the same parameters etc. as the previous build.

I wouldn't be opposed to exposing a function like: database.CreateWorkspaceBuild. I'm not a massive fan either, because it certainly conflicts with database.InsertWorkspaceBuild. 🤷

Originally posted by @kylecarbs in #1183 (comment)

When we have another (third) valid use-case for this, extract a helper function to streamline creating a new workspace build.

Activity

  1. tjcran commented on May 16, 2022

    @tjcran

    @johnstcn is this something needed for the Community MVP? Or is this a later thing?

  2. johnstcn commented on May 16, 2022

    @johnstcn
    MemberAuthor

    @tjcran this is just a code hygiene thing and not required for any functionality in particular.

  3. added this to the Post-MVP milestone on May 16, 2022
  4. changed the title [-]chore: extract helper function for creating a new workspace build[/-] [+]Extract helper function for creating a new workspace build[/+] on Jun 7, 2022
  5. added
    apiArea: HTTP API
    siteArea: frontend dashboard
    on Jun 14, 2022
  6. removed this from the Post-MVP milestone on Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    apiArea: HTTP APIsiteArea: frontend dashboard

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions