You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Disable the provisionerd HTTP endpoint and migrate the in-process provisionerd to an in-process communication mechanism.
Why do you want this feature?
Right now we start provisionerd in the same process as coderd, and we don't have any mechanism to start a stand-alone provisionerd. However, that provisionerd communicates with coderd over an unsecured http endpoint.
The endpoint is needed when we have a stand-alone provisionerd, and it needs to be secure, but securing it now feels premature because the security needs will be very different compared with an in-process provisionerd.
Are there any workarounds to get this functionality today?
Right now the endpoint provisionerd uses to connect to coderd is wide open for anyone to connect to. A malicious person could connect and steal cloud credentials, user SSH private keys, etc. It's real bad; like we shouldn't even be dogfooding until this is fixed. The only thing mitigating this now is that we're the only ones who have the protobuf definitions for what that endpoint expects to get. That changes as soon as we open source, so either this or #44 should be a hard switch blocker.
Activity
misskniss commentedon May 11, 2022
Hey team! Please add your planning poker estimate with ZenHub @spikecurtis @kylecarbs
ketang commentedon May 15, 2022
What happens if we don't do this?
spikecurtis commentedon May 16, 2022
@ketang @misskniss If we don't do either this or #44 , it's Bad News Bears.
Right now the endpoint provisionerd uses to connect to coderd is wide open for anyone to connect to. A malicious person could connect and steal cloud credentials, user SSH private keys, etc. It's real bad; like we shouldn't even be dogfooding until this is fixed. The only thing mitigating this now is that we're the only ones who have the protobuf definitions for what that endpoint expects to get. That changes as soon as we open source, so either this or #44 should be a hard switch blocker.
greyscaled commentedon May 16, 2022
Should we group this in with #44 (since it's an epic) and label the epic as a switch blocker?Edit: Nvm, I see this is tracked in a similar epic, but for CE