Skip to content

Feat: in-process provisionerd uses in-process communication; disable provisionerd http endpoint #1375

Closed

Description

@spikecurtis

What is your suggestion?

Disable the provisionerd HTTP endpoint and migrate the in-process provisionerd to an in-process communication mechanism.

Why do you want this feature?

Right now we start provisionerd in the same process as coderd, and we don't have any mechanism to start a stand-alone provisionerd. However, that provisionerd communicates with coderd over an unsecured http endpoint.

The endpoint is needed when we have a stand-alone provisionerd, and it needs to be secure, but securing it now feels premature because the security needs will be very different compared with an in-process provisionerd.

Are there any workarounds to get this functionality today?

n/a

Are you interested in submitting a PR for this?

yes

Activity

  1. added this to the Community MVP milestone on May 11, 2022
  2. misskniss commented on May 11, 2022

    @misskniss
  3. ketang commented on May 15, 2022

    @ketang
    Contributor

    What happens if we don't do this?

  4. spikecurtis commented on May 16, 2022

    @spikecurtis
    CollaboratorAuthor

    @ketang @misskniss If we don't do either this or #44 , it's Bad News Bears.

    Right now the endpoint provisionerd uses to connect to coderd is wide open for anyone to connect to. A malicious person could connect and steal cloud credentials, user SSH private keys, etc. It's real bad; like we shouldn't even be dogfooding until this is fixed. The only thing mitigating this now is that we're the only ones who have the protobuf definitions for what that endpoint expects to get. That changes as soon as we open source, so either this or #44 should be a hard switch blocker.

  5. greyscaled commented on May 16, 2022

    @greyscaled
    Contributor

    Should we group this in with #44 (since it's an epic) and label the epic as a switch blocker?


    Edit: Nvm, I see this is tracked in a similar epic, but for CE

  6. self-assigned this
    on May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

apiArea: HTTP API

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions