You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Bug: can't use Backspace in "Specify a name for your workspace" #1226
Introduced by #839 which, now that I look at it, has the helpful comment:
// This removes canonical input processing, so deletes will not function
// as expected. This seems fine for most use-cases, but is unfortunate.
So, we need to either live with inability to paste long lines, or inability to delete, or find/build a new input solution that supports both. Possibly some sort of text-UI/ncurses library? Your thoughts @kylecarbs@jsjoeio@bpmct
Considering the macOS terminal doesn't support extremely long lines, I'd say we should keep to that idiom. Maybe we prefer tfvars or something instead? That's what Terraform does.
I mean, presumably people can still pipe long-line inputs from file, so there is a workaround. Unclear the context when long-line pastes were causing grief. It's easy to see the grief from not being able to use backspace on a text prompt...
Another idea is to make the long line / backspace works choice on a prompt by prompt basis. So, prompts where we expect to have people primarily paste long stuff, we pick long lines. Not very satisfying, and adds a new option every time we open a prompt, but might minimize the pain.
Because Terraform doesn't support long input prompts like this, I'm tempted to say we should use tfvars instead. They also have this restriction (because it's just a macOS terminal thing).
My input would be that we favor the ability to delete/backspace over the ability to have long-input lines.
Adding a flag for long input or a prompt-by-prompt basis is something we can wait on until we get requests for it or are looking to enhance the experience.
Being able to backspace when you typo or want to change it up is pretty core expectations.
Activity
bpmct commentedon May 3, 2022
potential duplicate of #1173
jsjoeio commentedon May 3, 2022
Oh dang, it is a duplicate. My bad! Should we close this one?
spikecurtis commentedon May 4, 2022
Introduced by #839 which, now that I look at it, has the helpful comment:
So, we need to either live with inability to paste long lines, or inability to delete, or find/build a new input solution that supports both. Possibly some sort of text-UI/ncurses library? Your thoughts @kylecarbs @jsjoeio @bpmct
kylecarbs commentedon May 4, 2022
Considering the macOS terminal doesn't support extremely long lines, I'd say we should keep to that idiom. Maybe we prefer
tfvarsor something instead? That's what Terraform does.spikecurtis commentedon May 4, 2022
I mean, presumably people can still pipe long-line inputs from file, so there is a workaround. Unclear the context when long-line pastes were causing grief. It's easy to see the grief from not being able to use backspace on a text prompt...
spikecurtis commentedon May 6, 2022
Another idea is to make the long line / backspace works choice on a prompt by prompt basis. So, prompts where we expect to have people primarily paste long stuff, we pick long lines. Not very satisfying, and adds a new option every time we open a prompt, but might minimize the pain.
kylecarbs commentedon May 6, 2022
Maybe even display a keybind to allow long inputs? That'd be a pretty great user experience.
spikecurtis commentedon May 6, 2022
I'm not sure I know what you mean by a keybind.
spikecurtis commentedon May 6, 2022
Adding a flag that forces
--allow-long-inputswould be straightforward as well.kylecarbs commentedon May 6, 2022
Because Terraform doesn't support long input prompts like this, I'm tempted to say we should use
tfvarsinstead. They also have this restriction (because it's just a macOS terminal thing).spikecurtis commentedon May 6, 2022
literal
.tfvars, or just the idea of allowing input variables to be set in a file, like.codervars?kylecarbs commentedon May 6, 2022
Not sure, but
.tfvarsseems reasonable because then we wouldn't need input parameters.tjcran commentedon May 7, 2022
My input would be that we favor the ability to delete/backspace over the ability to have long-input lines.
Adding a flag for long input or a prompt-by-prompt basis is something we can wait on until we get requests for it or are looking to enhance the experience.
Being able to backspace when you typo or want to change it up is pretty core expectations.
tjcran commentedon May 7, 2022
Adding estimate of 1 to match the estimate in #1173, which is now closed as a duplicate of this one.
spikecurtis commentedon May 10, 2022
I've added #1377 to track loading parameter values from file.