Skip to content

Chore: Add missing read perm to RoleAuditor #1074

Closed

Description

@greyscaled

Overview

This comment was in rbac > role.go for RoleAuditor:

// TODO: @emyrk when audit logs are added, add back a read perm

This is blocked by audit log backend.

See #1066

Activity

  1. added this to the Community MVP milestone on May 17, 2022
  2. misskniss commented on May 17, 2022

    @misskniss

    @Emyrk does this get fixed with the PR you are currently working on? Also this does seem like something that is a switch blocker, yes?

  3. misskniss commented on May 17, 2022

    @misskniss
  4. Emyrk commented on May 17, 2022

    @Emyrk
    Member

    @misskniss it does not. It isn't relevant until audit logs are in though.

  5. Emyrk commented on Jun 1, 2022

    @Emyrk
    Member

    Can we just delete this? We don't have audit logs, so this can't be done. I shouldn't have added the auditor role probably...

    When audit logs are added, this is a 1 line change.

  6. Emyrk commented on Jun 2, 2022

    @Emyrk
    Member

    This is not worth an issue right now. When we add audit logs, we should update the Auditor role. I think that is apart of the Audit log effort.

    Closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

apiArea: HTTP API

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions