Repository navigation
Expand file tree
/
Copy pathchat_projects_test.go
More file actions
371 lines (319 loc) · 14.8 KB
/
Copy pathchat_projects_test.go
File metadata and controls
371 lines (319 loc) · 14.8 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
package coderd_test
import (
"net/http"
"strings"
"testing"
"github.com/google/uuid"
"github.com/stretchr/testify/require"
"github.com/coder/coder/v2/coderd/coderdtest"
"github.com/coder/coder/v2/coderd/database"
"github.com/coder/coder/v2/coderd/database/dbgen"
"github.com/coder/coder/v2/coderd/rbac"
"github.com/coder/coder/v2/codersdk"
"github.com/coder/coder/v2/testutil"
"github.com/coder/serpent"
)
func TestChatProjectsCRUDListAndDeleteDetaches(t *testing.T) {
t.Parallel()
ctx := testutil.Context(t, testutil.WaitLong)
client, db := newChatProjectClient(t)
firstUser := coderdtest.CreateFirstUser(t, client.Client)
_ = createChatModel(t, client)
project := createChatProject(t, client, firstUser.OrganizationID, "Project One")
otherOrganization := dbgen.Organization(t, db, database.Organization{IsDefault: false})
otherOrganizationProject := dbgen.ChatProject(t, db, database.ChatProject{
OrganizationID: otherOrganization.ID,
OwnerID: firstUser.UserID,
Name: "Other Organization Project",
})
// The list spans organizations so clients can load it in one request.
projects, err := client.ListChatProjects(ctx)
require.NoError(t, err)
require.ElementsMatch(t,
[]uuid.UUID{project.ID, otherOrganizationProject.ID},
[]uuid.UUID{projects[0].ID, projects[1].ID},
)
chat := createChatInProject(t, client, firstUser.OrganizationID, &project.ID)
fetched, err := client.GetChatProject(ctx, firstUser.OrganizationID, project.ID)
require.NoError(t, err)
require.Equal(t, project.ID, fetched.ID)
// The project exists and is readable, but not under this organization.
_, err = client.GetChatProject(ctx, otherOrganization.ID, project.ID)
require.Equal(t, 404, coderdtest.SDKError(t, err).StatusCode())
updatedName := "Renamed Project"
updatedDescription := "Updated description"
updatedIcon := " /emojis/1f680.png "
updated, err := client.UpdateChatProject(ctx, firstUser.OrganizationID, project.ID, codersdk.UpdateChatProjectRequest{
Name: &updatedName,
Description: &updatedDescription,
Icon: &updatedIcon,
})
require.NoError(t, err)
require.Equal(t, updatedName, updated.Name)
require.Equal(t, updatedDescription, updated.Description)
require.Equal(t, "/emojis/1f680.png", updated.Icon)
// Omitted fields keep their stored values.
keptName := "Renamed Again"
updated, err = client.UpdateChatProject(ctx, firstUser.OrganizationID, project.ID, codersdk.UpdateChatProjectRequest{Name: &keptName})
require.NoError(t, err)
require.Equal(t, "/emojis/1f680.png", updated.Icon)
longIcon := strings.Repeat("x", 257)
_, err = client.UpdateChatProject(ctx, firstUser.OrganizationID, project.ID, codersdk.UpdateChatProjectRequest{Icon: &longIcon})
requireChatProjectFieldError(t, err, "icon", "Icon must be at most 256 characters.")
blankName := " "
_, err = client.UpdateChatProject(ctx, firstUser.OrganizationID, project.ID, codersdk.UpdateChatProjectRequest{Name: &blankName})
requireChatProjectFieldError(t, err, "name", "Name must not be blank.")
// Names are labels, not identifiers: the same owner may reuse one
// through create or rename, and each project stays addressable by ID.
duplicate := createChatProject(t, client, firstUser.OrganizationID, keptName)
require.Equal(t, keptName, duplicate.Name)
require.NotEqual(t, project.ID, duplicate.ID)
duplicateAgain := createChatProject(t, client, firstUser.OrganizationID, keptName)
require.NotEqual(t, duplicate.ID, duplicateAgain.ID)
projects, err = client.ListChatProjects(ctx)
require.NoError(t, err)
var sameName []uuid.UUID
for _, listed := range projects {
if listed.Name == keptName {
sameName = append(sameName, listed.ID)
}
}
require.ElementsMatch(t, []uuid.UUID{project.ID, duplicate.ID, duplicateAgain.ID}, sameName)
fetched, err = client.GetChatProject(ctx, firstUser.OrganizationID, duplicate.ID)
require.NoError(t, err)
require.Equal(t, duplicate.ID, fetched.ID)
require.NoError(t, client.DeleteChatProject(ctx, firstUser.OrganizationID, project.ID))
storedChat, err := client.GetChat(ctx, chat.ID)
require.NoError(t, err)
require.Nil(t, storedChat.ProjectID)
}
func TestChatProjectsAuthorizationAndCrossOrganizationBinding(t *testing.T) {
t.Parallel()
ctx := testutil.Context(t, testutil.WaitLong)
client, db := newChatProjectClient(t)
firstUser := coderdtest.CreateFirstUser(t, client.Client)
_ = createChatModel(t, client)
project := createChatProject(t, client, firstUser.OrganizationID, "Protected Project")
// Projects are private to their creator until shared: another member
// neither sees nor can bind chats to it.
memberRaw, _ := coderdtest.CreateAnotherUser(t, client.Client, firstUser.OrganizationID)
member := codersdk.NewExperimentalClient(memberRaw)
_, err := member.GetChatProject(ctx, firstUser.OrganizationID, project.ID)
require.Equal(t, 404, coderdtest.SDKError(t, err).StatusCode())
projects, err := member.ListChatProjects(ctx)
require.NoError(t, err)
require.Empty(t, projects)
_, err = member.CreateChat(ctx, codersdk.CreateChatRequest{
OrganizationID: firstUser.OrganizationID,
ProjectID: &project.ID,
Content: []codersdk.ChatInputPart{{
Type: codersdk.ChatInputPartTypeText,
Text: "reject private project",
}},
})
requireChatProjectNotFound(t, err)
_, err = member.UpdateChatProject(ctx, firstUser.OrganizationID, project.ID, codersdk.UpdateChatProjectRequest{})
require.Equal(t, 404, coderdtest.SDKError(t, err).StatusCode())
err = member.DeleteChatProject(ctx, firstUser.OrganizationID, project.ID)
require.Equal(t, 404, coderdtest.SDKError(t, err).StatusCode())
// Members still create their own projects, which only they see.
memberProject := createChatProject(t, member, firstUser.OrganizationID, "Member Project")
projects, err = member.ListChatProjects(ctx)
require.NoError(t, err)
require.Len(t, projects, 1)
require.Equal(t, memberProject.ID, projects[0].ID)
// Like chats, the list holds only the caller's own projects, even for a
// site owner who can read others' projects by ID.
projects, err = client.ListChatProjects(ctx)
require.NoError(t, err)
require.Len(t, projects, 1)
require.Equal(t, project.ID, projects[0].ID)
_, err = client.GetChatProject(ctx, firstUser.OrganizationID, memberProject.ID)
require.NoError(t, err)
otherOrganization := dbgen.Organization(t, db, database.Organization{IsDefault: false})
otherProject := dbgen.ChatProject(t, db, database.ChatProject{
OrganizationID: otherOrganization.ID,
OwnerID: firstUser.UserID,
Name: "Other Project",
})
otherMemberRaw, _ := coderdtest.CreateAnotherUser(t, client.Client, otherOrganization.ID)
otherMember := codersdk.NewExperimentalClient(otherMemberRaw)
_, err = otherMember.GetChatProject(ctx, otherOrganization.ID, project.ID)
require.Equal(t, 404, coderdtest.SDKError(t, err).StatusCode())
_, err = client.CreateChat(ctx, codersdk.CreateChatRequest{
OrganizationID: firstUser.OrganizationID,
ProjectID: &otherProject.ID,
Content: []codersdk.ChatInputPart{{
Type: codersdk.ChatInputPartTypeText,
Text: "reject cross-organization project",
}},
})
sdkErr := coderdtest.SDKError(t, err)
require.Equal(t, 400, sdkErr.StatusCode())
require.Equal(t, "Chat project does not belong to this chat's organization.", sdkErr.Message)
adminRaw, _ := coderdtest.CreateAnotherUser(t, client.Client, firstUser.OrganizationID,
rbac.ScopedRoleOrgAdmin(firstUser.OrganizationID))
admin := codersdk.NewExperimentalClient(adminRaw)
adminName := "Updated by admin"
_, err = admin.UpdateChatProject(ctx, firstUser.OrganizationID, project.ID, codersdk.UpdateChatProjectRequest{Name: &adminName})
require.NoError(t, err)
// The owner may create chats for other users, but binding one to the
// owner's project would expose its memory to someone who cannot read
// the project, so the chat owner must own the project. The response
// matches an unknown project so the check does not reveal existence.
_, memberUser := coderdtest.CreateAnotherUser(t, client.Client, firstUser.OrganizationID)
_, err = client.CreateChat(ctx, codersdk.CreateChatRequest{
OrganizationID: firstUser.OrganizationID,
OwnerID: &memberUser.ID,
ProjectID: &project.ID,
Content: []codersdk.ChatInputPart{{
Type: codersdk.ChatInputPartTypeText,
Text: "reject binding another user's chat",
}},
})
requireChatProjectNotFound(t, err)
missingProjectID := uuid.New()
_, err = client.CreateChat(ctx, codersdk.CreateChatRequest{
OrganizationID: firstUser.OrganizationID,
ProjectID: &missingProjectID,
Content: []codersdk.ChatInputPart{{
Type: codersdk.ChatInputPartTypeText,
Text: "reject missing project",
}},
})
requireChatProjectNotFound(t, err)
require.NoError(t, admin.DeleteChatProject(ctx, firstUser.OrganizationID, project.ID))
}
func TestChatProjectFieldLimits(t *testing.T) {
t.Parallel()
ctx := testutil.Context(t, testutil.WaitLong)
client, _ := newChatProjectClient(t)
firstUser := coderdtest.CreateFirstUser(t, client.Client)
_, err := client.CreateChatProject(ctx, firstUser.OrganizationID, codersdk.CreateChatProjectRequest{
Name: strings.Repeat("n", 65),
})
requireChatProjectFieldError(t, err, "name", "Name must be at most 64 characters.")
_, err = client.CreateChatProject(ctx, firstUser.OrganizationID, codersdk.CreateChatProjectRequest{
Name: " ",
})
requireChatProjectFieldError(t, err, "name", "Name is required.")
// Surrounding whitespace is trimmed before the length check.
project := createChatProject(t, client, firstUser.OrganizationID, " "+strings.Repeat("n", 64)+" ")
require.Equal(t, strings.Repeat("n", 64), project.Name)
longDescription := strings.Repeat("d", 1025)
_, err = client.UpdateChatProject(ctx, firstUser.OrganizationID, project.ID, codersdk.UpdateChatProjectRequest{Description: &longDescription})
requireChatProjectFieldError(t, err, "description", "Description must be at most 1024 characters.")
}
func TestChatProjectLimit(t *testing.T) {
t.Parallel()
ctx := testutil.Context(t, testutil.WaitLong)
client, db := newChatProjectClient(t)
firstUser := coderdtest.CreateFirstUser(t, client.Client)
// The cap counts the owner's projects in every organization.
otherOrganization := dbgen.Organization(t, db, database.Organization{})
var last database.ChatProject
for i := range 100 {
organizationID := firstUser.OrganizationID
if i%2 == 0 {
organizationID = otherOrganization.ID
}
last = dbgen.ChatProject(t, db, database.ChatProject{OrganizationID: organizationID, OwnerID: firstUser.UserID})
}
_, err := client.CreateChatProject(ctx, firstUser.OrganizationID, codersdk.CreateChatProjectRequest{Name: "One too many"})
require.Equal(t, http.StatusConflict, coderdtest.SDKError(t, err).StatusCode())
// Another user's projects do not count toward the cap.
memberRaw, _ := coderdtest.CreateAnotherUser(t, client.Client, firstUser.OrganizationID)
_ = createChatProject(t, codersdk.NewExperimentalClient(memberRaw), firstUser.OrganizationID, "Member project")
require.NoError(t, client.DeleteChatProject(ctx, last.OrganizationID, last.ID))
_ = createChatProject(t, client, firstUser.OrganizationID, "Fits after a delete")
}
func TestChatProjectListFilter(t *testing.T) {
t.Parallel()
ctx := testutil.Context(t, testutil.WaitLong)
client, _ := newChatProjectClient(t)
firstUser := coderdtest.CreateFirstUser(t, client.Client)
_ = createChatModel(t, client)
projectA := createChatProject(t, client, firstUser.OrganizationID, "Project A")
projectB := createChatProject(t, client, firstUser.OrganizationID, "Project B")
chat := createChatInProject(t, client, firstUser.OrganizationID, &projectA.ID)
otherChat := createChatInProject(t, client, firstUser.OrganizationID, &projectB.ID)
require.Equal(t, &projectA.ID, chat.ProjectID)
chats, err := client.ListChats(ctx, &codersdk.ListChatsOptions{ProjectID: &projectA.ID})
require.NoError(t, err)
require.Len(t, chats, 1)
require.Equal(t, chat.ID, chats[0].ID)
require.NotEqual(t, otherChat.ID, chats[0].ID)
// Membership is fixed at creation; the update endpoint ignores project_id.
require.NoError(t, client.UpdateChat(ctx, chat.ID, codersdk.UpdateChatRequest{Title: new("renamed")}))
updated, err := client.GetChat(ctx, chat.ID)
require.NoError(t, err)
require.Equal(t, &projectA.ID, updated.ProjectID)
}
func TestChatProjectsExperimentDisabled(t *testing.T) {
t.Parallel()
ctx := testutil.Context(t, testutil.WaitLong)
client, db := newChatClientWithDatabase(t, withChatWorkerDisabled)
firstUser := coderdtest.CreateFirstUser(t, client.Client)
_ = createChatModel(t, client)
// The project routes bypass the experiment in development builds, so
// seed the row directly and exercise chat creation, which does not.
project := dbgen.ChatProject(t, db, database.ChatProject{
OrganizationID: firstUser.OrganizationID,
OwnerID: firstUser.UserID,
Name: "Off",
})
_, err := client.CreateChat(ctx, codersdk.CreateChatRequest{
OrganizationID: firstUser.OrganizationID,
ProjectID: &project.ID,
Content: []codersdk.ChatInputPart{{Type: codersdk.ChatInputPartTypeText, Text: "experiment off"}},
})
require.Equal(t, 400, coderdtest.SDKError(t, err).StatusCode())
_, err = client.ListChats(ctx, &codersdk.ListChatsOptions{ProjectID: &project.ID})
require.Equal(t, 400, coderdtest.SDKError(t, err).StatusCode())
}
func newChatProjectClient(t testing.TB) (*codersdk.ExperimentalClient, database.Store) {
t.Helper()
client, db := newChatClientWithDatabase(t,
func(options *coderdtest.Options) {
options.DeploymentValues.Experiments = serpent.StringArray{
string(codersdk.ExperimentChatProjects),
}
},
withChatWorkerDisabled,
)
return client, db
}
func createChatProject(t testing.TB, client *codersdk.ExperimentalClient, organizationID uuid.UUID, name string) codersdk.ChatProject {
t.Helper()
project, err := client.CreateChatProject(testutil.Context(t, testutil.WaitLong), organizationID, codersdk.CreateChatProjectRequest{
Name: name,
})
require.NoError(t, err)
return project
}
func requireChatProjectFieldError(t testing.TB, err error, field, detail string) {
t.Helper()
sdkErr := coderdtest.SDKError(t, err)
require.Equal(t, 400, sdkErr.StatusCode())
require.Equal(t, detail, sdkErr.Message)
require.Equal(t, []codersdk.ValidationError{{Field: field, Detail: detail}}, sdkErr.Validations)
}
func requireChatProjectNotFound(t testing.TB, err error) {
t.Helper()
sdkErr := coderdtest.SDKError(t, err)
require.Equal(t, 404, sdkErr.StatusCode())
require.Equal(t, "Chat project not found.", sdkErr.Message)
}
func createChatInProject(t testing.TB, client *codersdk.ExperimentalClient, organizationID uuid.UUID, projectID *uuid.UUID) codersdk.Chat {
t.Helper()
chat, err := client.CreateChat(testutil.Context(t, testutil.WaitLong), codersdk.CreateChatRequest{
OrganizationID: organizationID,
ProjectID: projectID,
Content: []codersdk.ChatInputPart{{
Type: codersdk.ChatInputPartTypeText,
Text: "chat project coverage",
}},
})
require.NoError(t, err)
return chat
}