fix: preserve path and query in openExternal URL rewrite#7842
Open
1795771535y-cell wants to merge 1 commit into
Open
fix: preserve path and query in openExternal URL rewrite#78421795771535y-cell wants to merge 1 commit into
1795771535y-cell wants to merge 1 commit into
Conversation
The resolveExternalUri function in the proxy-uri patch was discarding the original URI path and query parameters when rewriting localhost URLs to go through the code-server proxy. Before: http://127.0.0.1:1234/my/path?q=1 -> /proxy/1234/ After: http://127.0.0.1:1234/my/path?q=1 -> /proxy/1234/my/path?q=1 Fixes coder#7668
code-asher
reviewed
Jun 10, 2026
code-asher
left a comment
code-asher
left a comment
Member
There was a problem hiding this comment.
Thank you for fixing this!
| + resolvedUri = URI.parse(proxyUrl.toString()) | ||
| + } else { | ||
| + throw new Error(`Failed to resolve external URI: ${uri.toString()}. Could not determine base url because productConfiguration missing.`) | ||
| + throw new Error(Failed to resolve external URI: ${uri.toString()}. Could not determine base url because productConfiguration missing.) |
Member
There was a problem hiding this comment.
Looks like the backticks may have been accidentally dropped. The argument here to Error should be a string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7668: The
esolveExternalUri function in the proxy-uri patch was discarding the original URI path and query parameters when rewriting localhost URLs to go through the code-server proxy.
Before
http://127.0.0.1:1234/my/path?q=1→/proxy/1234/After
http://127.0.0.1:1234/my/path?q=1→/proxy/1234/my/path?q=1Changes
/stripped) to the proxy URL pathnameTesting
The fix preserves the path and query parameters from localhost URLs when they are rewritten through the code-server proxy endpoint template.