Fix 670#722
Closed
geiseri wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
@kylecarbs or @code-asher bump? |
code-asher
approved these changes
Jun 10, 2019
Member
|
Thanks! Merging is blocked until all commits are signed. 🔑 |
Closed
Member
|
@geiseri Could you please sign these commits with PGP using git's amend function and force push to your fork? |
Contributor
Author
|
Yah, I am not sure I have a key that is associated with my github account though. Let me get that sorted. |
Member
|
Bump @geiseri |
This was referenced Jun 26, 2019
Contributor
|
@geiseri you can check if your PGP signature is being used globally. |
Member
|
Closing for inactivity. I'll open a new PR in a sec with the same changes. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #670 by making the service worker register at the base of the mount. I also changed it so that workbox is hosted from local and not a CDN. This helps simplify CSP issues that pop up when mounting as part of a larger site. There are still quite a few other ones once we start talking plugins but this is a start.