Skip to content

fix Dockerfile#71

Closed
yush1ga wants to merge 1 commit into
coder:masterfrom
yush1ga:fix-dockefile
Closed

fix Dockerfile#71
yush1ga wants to merge 1 commit into
coder:masterfrom
yush1ga:fix-dockefile

Conversation

@yush1ga

@yush1ga yush1ga commented Mar 7, 2019

Copy link
Copy Markdown

Thanks for making this awesome soft open source.

Unfortunately, Dockerfile doesn't work in my environment.
It may depend on os arch environment.

I tried to fix it by tweaking Dockerfile.

@kylecarbs kylecarbs requested review from nhooyr and removed request for code-asher and kylecarbs March 7, 2019 17:37
@nhooyr

nhooyr commented Mar 7, 2019

Copy link
Copy Markdown
Contributor

Could you elaborate on the error/issue you were having? I don't see what this fixes.

@code-asher

Copy link
Copy Markdown
Member

Ah, probably because I added the architecture to the binary name here: 994531d#diff-09fded6ea343c3bb08cac161ed7a3cbaR17

@nhooyr

nhooyr commented Mar 7, 2019

Copy link
Copy Markdown
Contributor

Dammit Asher. I'll push a fix for this. Thanks for pointing this out @yush1ga

@nhooyr

nhooyr commented Mar 7, 2019

Copy link
Copy Markdown
Contributor

See #109

@nhooyr nhooyr closed this Mar 7, 2019
@yush1ga

yush1ga commented Mar 8, 2019

Copy link
Copy Markdown
Author

@nhooyr @coderasher Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants