Remove reveal in finder#586
Merged
Merged
Conversation
kylecarbs
approved these changes
Apr 24, 2019
|
Thanks guys! |
andreimc
added a commit
to devonlineco/code-server
that referenced
this pull request
May 14, 2019
* upstream/master: (68 commits) Fix docker oneliner in README.md Fix macOS release Rename codercom/code-server to cdr/code-server Expose Terminal Service in API Make preserveEnv return a new object Preserve environment when forking shared process (coder#545) codercom -> cdr Package only on darwin Include version with target env Add docker service Add support for musl and centos Remove reveal in finder/explorer option from the context menu (coder#586) Fix open dialog crash when there is a broken link Only output password if it was generated Fix full screen detection for Chromium Fix toggling full screen Improve size column in dialogs Fix typo DigitalOcean (coder#595) Fix coder#587 (coder#588) Fix protocol fs test ...
code-asher
pushed a commit
that referenced
this pull request
Jun 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe in detail the problem you had and how this PR fixes it
The "reveal in finder/explorer" option has no utility in the browser and causes a page to reload to invoke. This PR simply removes the option from the context menu to avoid mistakenly causing a refresh/confusion.
Is there an open issue you can link to?
fixes #576