Repository navigation
fix(terminal): use window.location to work when served NOT on root path - #5332
Merged
Merged
Conversation
|
✨ code-server docs for PR #5332 is ready! It will be updated on every commit.
|
Codecov Report
@@ Coverage Diff @@
## main #5332 +/- ##
=======================================
Coverage 72.47% 72.47%
=======================================
Files 30 30
Lines 1671 1671
Branches 367 367
=======================================
Hits 1211 1211
Misses 397 397
Partials 63 63 Continue to review full report at Codecov.
|
jsjoeio
force-pushed
the
jsjoeio/fix-terminal
branch
from
July 13, 2022 23:49
0e5df64 to
2b339bc
Compare
When using `window.location.origin` to create a new URL for loading web packages, it constructs a URL that is not relative, leading to the terminal breaking when code-server is served not via the root (i.e. /ide instead of /).
jsjoeio
force-pushed
the
jsjoeio/fix-terminal
branch
from
July 13, 2022 23:52
2b339bc to
eadad9f
Compare
Contributor
Author
This was referenced Jul 14, 2022
4 tasks done
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
We made a change in
workbench-dev.htmlbut forgot to make it inworkbench.html. This fixes the Integrated Terminal to work when code-server is served NOT on the root path (i.e. accessed at/vscodeinstead of/).Fixes #5321