fix NOTE.txt#4515
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4515 +/- ##
=======================================
Coverage 66.03% 66.03%
=======================================
Files 30 30
Lines 1640 1640
Branches 330 330
=======================================
Hits 1083 1083
Misses 474 474
Partials 83 83 Continue to review full report at Codecov.
|
Contributor
|
Hey @Matthew-Beckett - do you mind helping me review this PR? I think it looks good but wanted to get your take since you know this part of the codebase better than me! |
Matthew-Beckett
approved these changes
Nov 16, 2021
Matthew-Beckett
left a comment
Matthew-Beckett
left a comment
Contributor
There was a problem hiding this comment.
Changes don't affect chart function, just "cosmetic".
Contributor
|
Thanks for your contribution @jlandowner this is definitely better! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4504
Currently fetching Pod, but I think it is better to use Service directly.