Avoid npx for Playwright dependencies#4437
Merged
Merged
Conversation
jawnsy
reviewed
Nov 3, 2021
Codecov Report
@@ Coverage Diff @@
## main #4437 +/- ##
=======================================
Coverage 66.29% 66.29%
=======================================
Files 31 31
Lines 1620 1620
Branches 316 316
=======================================
Hits 1074 1074
Misses 468 468
Partials 78 78 Continue to review full report at Codecov.
|
code-asher
force-pushed
the
playwright-install
branch
2 times, most recently
from
211f8f5 to
944f490
Compare
code-asher
changed the title
7 tasks
It was causing version mismatch errors. It might make more sense to have this in the postinstall but for now I have foregone that as it would be installed in every step including those that do not run e2e tests.
code-asher
force-pushed
the
playwright-install
branch
from
944f490 to
457299a
Compare
code-asher
changed the title
jsjoeio
approved these changes
Nov 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was causing version mismatch errors.
It might make more sense to have this in the postinstall but for now I
have foregone that as it would be installed in every step including
those that do not run e2e tests.