Add serviceworker + Monaco Service Worker#411
Closed
andreimc wants to merge 10 commits into
Closed
Conversation
Contributor
|
Does this add web workers or does it add service workers? AFAIK Monaco uses web workers rather than service workers, because Monaco doesn't have to do background processing, rather it does parallel processing. If this is the case this should not be merged together with the "Service worker and PWA" PR as it is not related. You might be confused by Monaco's "language server service" workers, which are not service workers but rather just regular web workers which are running a "language server service". (https://www.quora.com/Whats-the-difference-between-service-workers-and-web-workers-in-JavaScript) |
Author
|
@creativeguy2013 you are right 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#154 original PR, rebased and fixed conflicts
Describe in detail the problem you had and how this PR fixes it
Also added monaco webpack plugin which enables monaco to operate via the service worker.
Is there an open issue you can link to?
#375