Skip to content

Removed files that are in .gitignore but still in the tree#380

Closed
MOZGIII wants to merge 1 commit into
coder:masterfrom
MOZGIII:gitignore-corrections
Closed

Removed files that are in .gitignore but still in the tree#380
MOZGIII wants to merge 1 commit into
coder:masterfrom
MOZGIII:gitignore-corrections

Conversation

@MOZGIII

@MOZGIII MOZGIII commented Mar 29, 2019

Copy link
Copy Markdown
Contributor

Describe in detail the problem you had and how this PR fixes it

I'm doing the packing for debian, and I found out there are somes that are in the .gitignore (git clean -Xdf removes them) but they're in the tree. It cases some problems for the way I'm trying to package things.
Those files were probably added by mistake, so this PR removes them.

Is there an open issue you can link to?

Not that I'm aware of.

@code-asher

code-asher commented Mar 29, 2019

Copy link
Copy Markdown
Member

These are part of the requirefs tests and shouldn't be removed. We should probably un-ignore the lib folder there. We do that for lib/node_modules but not lib: https://github.com/codercom/code-server/blob/master/packages/requirefs/test/.gitignore#L1

We could also rename lib to something else. Maybe something like fixtures?

@MOZGIII

MOZGIII commented Mar 29, 2019

Copy link
Copy Markdown
Contributor Author

I'm closing this PR then. At which level do you prefer them unignored?

@MOZGIII MOZGIII closed this Mar 29, 2019
@code-asher

code-asher commented Mar 29, 2019

Copy link
Copy Markdown
Member

I think it'd actually be better to rename the directory to fixtures.

@MOZGIII

MOZGIII commented Mar 29, 2019

Copy link
Copy Markdown
Contributor Author

Is the pattern in this repo to ignore all the lib dirs? Or maybe it should be /lib instead of lib at the top level?

@code-asher

Copy link
Copy Markdown
Member

Ah, that's a good point, we could just ignore /lib at the top level. That sounds good to me.

@MOZGIII MOZGIII deleted the gitignore-corrections branch April 1, 2019 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants