Skip to content

Fix install from VSIX for TAR and ZIP formats#245

Merged
kylecarbs merged 2 commits into
coder:masterfrom
foresthoffman:master
Mar 21, 2019
Merged

Fix install from VSIX for TAR and ZIP formats#245
kylecarbs merged 2 commits into
coder:masterfrom
foresthoffman:master

Conversation

@foresthoffman

Copy link
Copy Markdown
Contributor

Describe in detail the problem you had and how this PR fixes it

Fixes installing extensions from VSIX files formatted as either TAR or ZIP.

Is there an open issue you can link to?

Fixes #92

@NGTmeaty NGTmeaty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread packages/vscode/src/fill/zip.ts Outdated
@foresthoffman foresthoffman requested a review from kylecarbs March 20, 2019 21:20
@kylecarbs kylecarbs merged commit 18f395b into coder:master Mar 21, 2019
code-asher pushed a commit that referenced this pull request Jun 19, 2019
* Fix install from VSIX for TAR and ZIP formats

* Parse TAR before ZIP, when installing from VSIX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detect archive type of extension to decompress

3 participants