Skip to content

Another fix for the Dockerfile and build#188

Merged
kylecarbs merged 2 commits into
masterfrom
anmol
Mar 11, 2019
Merged

Another fix for the Dockerfile and build#188
kylecarbs merged 2 commits into
masterfrom
anmol

Conversation

@nhooyr

@nhooyr nhooyr commented Mar 10, 2019

Copy link
Copy Markdown
Contributor

No description provided.

ENTRYPOINT must be provided in exec form for args
from docker run to be passed correctly.

See https://docs.docker.com/engine/reference/builder/#cmd

@avelino avelino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nhooyr nhooyr mentioned this pull request Mar 11, 2019
@kylecarbs kylecarbs merged commit 03c0bde into master Mar 11, 2019
@kylecarbs kylecarbs deleted the anmol branch March 11, 2019 14:47
code-asher pushed a commit that referenced this pull request Jun 19, 2019
* Dockerfile: fix

ENTRYPOINT must be provided in exec form for args
from docker run to be passed correctly.

See https://docs.docker.com/engine/reference/builder/#cmd

* build: fix reuse of vscode repository regression

See #167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants