code-server version: 1.939-vsc1.33.1- OS Version: irrelevant
Description
We are running code-server behind a reverse proxy that uses paths instead of distinct domains. e.g. domain.com/ide/123456. The service-worker script introduced in #154 will try to load the script from domain.com/service-worker.js instead of domain.com/ide/123456/service-worker.js.
It should be sufficient (it's not) to remove the leading slash in navigator.serviceWorker.register("/service-worker.js");. So either navigator.serviceWorker.register("./service-worker.js"); or navigator.serviceWorker.register("service-worker.js");. But I haven't tested all scenarios, yet.
code-serverversion: 1.939-vsc1.33.1Description
We are running
code-serverbehind a reverse proxy that uses paths instead of distinct domains. e.g.domain.com/ide/123456. The service-worker script introduced in #154 will try to load the script fromdomain.com/service-worker.jsinstead ofdomain.com/ide/123456/service-worker.js.It should be sufficient(it's not) to remove the leading slash innavigator.serviceWorker.register("/service-worker.js");. So eithernavigator.serviceWorker.register("./service-worker.js");ornavigator.serviceWorker.register("service-worker.js");. But I haven't tested all scenarios, yet.