Skip to content

no need for the close/minimize/maximize buttons #320

Closed

Description

@shi-yan
  • code-server version: top of tree
  • OS Version: ubuntu 18.04 for both host and docker

Description

code-server still has the minimize, maximize and close window button on the top right corner. they are not functioning and should be removed.

Steps to Reproduce

Activity

  1. nol166 commented on Mar 25, 2019

    @nol166
    Contributor

    @shi-yan Can you send a screenshot when you get a chance?

  2. shi-yan commented on Mar 25, 2019

    @shi-yan
    Author

    Selection_004

    this is only a problem on linux, I don't see the same buttons on mac. (not sure about windows)

  3. nol166 commented on Mar 25, 2019

    @nol166
    Contributor

    @shi-yan Interesting. Thank you for sharing this

  4. shi-yan commented on Mar 25, 2019

    @shi-yan
    Author

    Screenshot from 2019-03-25 11-44-11

    you know, the other side of this bug is, on mac, you can't find the preference /setting menu. I don't have a mac at hand, so I can't show you the mac screenshot. but on linux, under the file menu, there is a preference /setting menu. this is not shown on mac. (so that I have no idea how to config preference.)

    I guess the electron replacement layer shows different UIs on different client platforms. it tries to look native, that's why we see the close button on linux and no preference menu on mac.

  5. nol166 commented on Mar 25, 2019

    @nol166
    Contributor

    If you use the command pallet does it let you get to the settings that way, either UI or JSON?

    Definitely a bug though

  6. self-assigned this
    on Apr 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions