Skip to content

Move manifest.json to root of project #1278

Description

@AdaRoseCannon

Description

Follow up to #1275

According to https://developer.mozilla.org/en-US/docs/Web/Manifest/start_url#Relative_URL

the start_url, if a relative URL like '.', should point to a path relative to the manifest.

After testing the install in Samsung Internet, this results in a broken link because it points to the folder containing the manifest:

localhost:8080/static-336ee288886f5728e1191e9ada2aeba5eb0bbd76/out/vs/server/src/media/

Which is the correct behaviour, but the expected behaviour is that it points to the root of the project.

The initial proposed fix was to change the start_url to the root but after discussion a better fix would be to restore the manifest.json to the root of the project and leave a note not to be moved in the future.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions