Skip to content

Updating SYCL For CUDA examples to CUDA 12 and latest intel llvm tip - #27

Merged
Ruyk merged 7 commits into
masterfrom
updates_23
Apr 19, 2023
Merged

Updating SYCL For CUDA examples to CUDA 12 and latest intel llvm tip#27
Ruyk merged 7 commits into
masterfrom
updates_23

Conversation

@Ruyk

@Ruyk Ruyk commented Feb 13, 2023

Copy link
Copy Markdown
  • Updating SGEMM interop for CUDA 12 and context interop changes
  • Updating vector addition to CUDA 12
  • Updating both to SYCL 2020 modern syntax

Ruyman Reyes Castro added 5 commits February 9, 2023 16:44
Works with latest DPC++ and SYCL2020 features
README updated to reflect CUDA backend has USM support
Since intel/llvm#8197, SYCL CUDA backend uses
CUDA primary context by default, so individual context setting is no
longer required.
SYCL 1.2.1 device selectors have been deprecated in favour of a new
simplified form using lambdas.
Run clang-format on files, separate commit to avoid noise
@Ruyk
Ruyk requested a review from joeatodd February 13, 2023 12:17
@Ruyk Ruyk self-assigned this Feb 13, 2023

@AerialMantis AerialMantis left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread examples/sgemm_interop/sycl_sgemm.cpp
Comment thread examples/vector_addition/vector_addition.cpp Outdated
Ruyman Reyes Castro added 2 commits April 19, 2023 17:13
Because of the changes on SYCL context, it is necessary now to set the
active CUDA context manually inside the host task.

Note there was some clang-formatting here as well

@AerialMantis AerialMantis left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@Ruyk
Ruyk merged commit 6bf6411 into master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants