Skip to content

Update CUDA examples to work with recent DPC++ - #12

Merged
Ruyk merged 2 commits into
masterfrom
update_cuda_examples
Dec 15, 2020
Merged

Update CUDA examples to work with recent DPC++#12
Ruyk merged 2 commits into
masterfrom
update_cuda_examples

Conversation

@Ruyk

@Ruyk Ruyk commented Dec 15, 2020

Copy link
Copy Markdown

No description provided.

@Ruyk
Ruyk requested a review from stuartdadams December 15, 2020 11:38
@Ruyk Ruyk self-assigned this Dec 15, 2020

@stuartdadams stuartdadams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread example-02/sycl_sgemm_interop_task.cpp Outdated
Comment thread example-02/sycl_sgemm.cpp Outdated
Comment thread example-02/sycl_sgemm.cpp Outdated
Comment thread example-02/sycl_sgemm.cpp
auto cuA = reinterpret_cast<float *>(ih.get_mem<backend::cuda>(d_A));
auto cuB = reinterpret_cast<float *>(ih.get_mem<backend::cuda>(d_B));
auto cuC = reinterpret_cast<float *>(ih.get_mem<backend::cuda>(d_C));
h.codeplay_host_task([=](sycl::interop_handle ih) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a handler that is called "codeplay_host_task" ? Why is it not just host_task?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a codeplay extension implemented by DPC++, rather than the SYCL 2020 feature, and that is how it is defined.

@Ruyk
Ruyk merged commit 1416d9e into master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants