Skip to content

enhance parser loading error reporting#2211

Open
sahilmob wants to merge 2 commits into
mainfrom
chore/enhance-parser-loading-error-reporting
Open

enhance parser loading error reporting#2211
sahilmob wants to merge 2 commits into
mainfrom
chore/enhance-parser-loading-error-reporting

Conversation

@sahilmob
Copy link
Copy Markdown
Contributor

📚 Description

This PR introduces an enhancement to error reporting when a dynamic parser download fails.

@sahilmob sahilmob requested a review from mohebifar May 13, 2026 21:43
Comment thread crates/tree-sitter-loader/src/lib.rs Outdated
@github-actions
Copy link
Copy Markdown
Contributor

Codex Review

The patch is mostly sound, but I found one correctness regression risk in the new download path and a coverage gap for the new behavior.

Findings

  • [MEDIUM] crates/tree-sitter-loader/src/lib.rs:156 download_parser can crash the process if thread creation fails
  • [LOW] No tests were added for the new download-thread and post-download symbol validation paths

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

TUI Perf Comparison

Focused Perf Regression Tests

Test Result
should_redraw_is_false_for_static_idle_ui_without_changes PASS
draw_counter_counts_only_initial_draw_for_static_idle_screen PASS
draw_counter_counts_one_redraw_for_burst_of_drained_workflow_events PASS
draw_counter_counts_deadline_tick_for_running_screen PASS
reduce_workflow_receiver_requests_snapshot_after_receiver_lag PASS
await_js_ast_grep_execution_task_returns_prompt_completion_without_polling_delay PASS
await_js_ast_grep_execution_task_prefers_completed_result_over_later_idle_signal PASS

Timed Perf Benchmarks

Benchmark Baseline median Candidate median Delta Ratio Result
jssg_wait_completion_latency 6 us 9 us +3 us 1.50x PASS
large_task_list_render_latency 7040 us 7010 us -30 us 1.00x PASS
publish_log_heavy_task_list_render_latency 7747 us 7623 us -124 us 0.98x PASS
log_modal_render_latency 595238 us 598484 us +3246 us 1.01x PASS

Fails only when candidate median is more than 25% slower and exceeds the benchmark-specific absolute floor.

TUI Perf Comparison

  • Baseline dir: perf-results/baseline
  • Candidate dir: perf-results/candidate

Completed

Metric Baseline Candidate Delta
deadline_wakeups 1 1 0
draws 1 1 0

Awaiting Trigger

Metric Baseline Candidate Delta
deadline_wakeups 1 1 0
draws 1 1 0

Active

Metric Baseline Candidate Delta
deadline_wakeups 4 4 0
draws 4 4 0

Awaiting Trigger Resume

Metric Baseline Candidate Delta
deadline_wakeups 1 1 0
draws 1 1 0

Active Busy

Metric Baseline Candidate Delta
deadline_wakeups 4 4 0
draws 4 4 0

Terminal Activity

Metric Baseline Candidate Delta
deadline_wakeups 1 1 0
draws 3 3 0
terminal_events 2 2 0
terminal_key_events 1 1 0
terminal_resize_events 1 1 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant