test(hvcs): add unit tests for upload_dists error cases and improve error messages #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add unit tests to capture error cases in GitHub HVCS upload_dists method: - Test authentication errors (401 Unauthorized) - Test forbidden errors (403 Forbidden) - Test various HTTP error codes (400, 404, 429, 500, 503) - Test partial upload failures (some succeed, some fail) - Test successful uploads - Verify error messages contain file and release information These tests address issues python-semantic-release#1395 and python-semantic-release/publish-action#77 where authentication errors did not bubble up clearly to users. Co-authored-by: codejedi365 <17354856+codejedi365@users.noreply.github.com>
Enhance error handling in GitHub HVCS upload_dists method to include HTTP status codes in error messages. This helps users quickly identify authentication (401), permission (403), and other HTTP errors when distribution uploads fail. Changes: - Capture HTTP status code from HTTPError response - Include status code in error messages (e.g., "HTTP 401", "HTTP 403") - Fix Response object boolean evaluation issue Tests updated to verify error messages include status codes. Co-authored-by: codejedi365 <17354856+codejedi365@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add unit tests for github hvcs upload_dists error handling
test(hvcs): add unit tests for upload_dists error cases and improve error messages
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Authentication and permission errors in
upload_distswere being caught but not surfaced with actionable details. Users saw generic failure messages without HTTP status codes, making debugging difficult in CI/CD environments.Rationale
The existing error handling caught
HTTPErrorexceptions but only logged generic messages like"failed to upload asset {file} to release {id}". Critical diagnostic information (HTTP status codes) was only in debug logs, not in the raised exception message.Changes
Test Coverage:
Error Message Enhancement:
HTTPError.response.status_code"failed to upload asset dist/pkg.whl to release 123 (HTTP 401)"Responseobject boolean evaluation correctly (evaluates toFalseeven when present)How did you test?
How to Verify
pytest tests/unit/semantic_release/hvcs/test_github.py -vtest_upload_dists_fails_*PR Completion Checklist
Reviewed & followed the Contributor Guidelines
Changes Implemented & Validation pipeline succeeds
Commits follow the Conventional Commits standard
and are separated into the proper commit type and scope (recommended order: test, build, feat/fix, docs)
Appropriate Unit tests added/updated
Appropriate End-to-End tests added/updated
Appropriate Documentation added/updated and syntax validated for sphinx build (see Contributor Guidelines)
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.