Fixed the renderer process crashing, removing javascript callbacks

Czarek · Czarek · commit d377aa82e454 · 2013-07-29T13:57:57.000+02:00
in OnContextReleased caused an infinite loop due to misuse of the
iterator when calling std::map.erase().
diff --git a/cefpython/cef3/subprocess/javascript_callback.cpp b/cefpython/cef3/subprocess/javascript_callback.cpp
@@ -85,10 +85,17 @@ void RemoveJavascriptCallbacksForFrame(CefRefPtr<CefFrame> frame) {
     int64 frameId = frame->GetIdentifier();
     while (it != g_jsCallbackMap.end()) {
         if (it->second.first->GetIdentifier() == frameId) {
-            g_jsCallbackMap.erase(it);
+            // Pass current iterator and increment it after passing
+            // to the function, but before erase() is called, this 
+            // is important for it to work in a loop. You can't do this:
+            // | if (..) erase(it);
+            // | ++it;
+            // This would cause an infinite loop.
+            g_jsCallbackMap.erase(it++);
             DebugLog("Renderer: RemoveJavascriptCallbacksForFrame(): " \
                     "removed js callback from the map");
+        } else {
+            ++it;
         }
-        ++it;
     }
 }
