enhancements to the HTML processing

jbcpollak · jbcpollak · commit f5ab0f36bf1d · 2013-04-27T09:19:09.000-04:00
diff --git a/cloudinary-taglib/src/main/java/com/cloudinary/taglib/CloudinaryUploadTag.java b/cloudinary-taglib/src/main/java/com/cloudinary/taglib/CloudinaryUploadTag.java
@@ -13,9 +13,15 @@
 
 public class CloudinaryUploadTag extends SimpleTagSupport {
 
-    private String resourceType = "auto";
+    // HTML basics
+    private String id = null;
+    private String name = "file";
+    private String extraClasses = null;
+    
+    // Cloudinary Specific
+    private String tags = null;
     private String fieldName;
-    private String extraClasses;
+    private String resourceType = "auto";
     
     public void doTag() throws JspException, IOException {
         Cloudinary cloudinary = Singleton.getCloudinary();
@@ -29,10 +35,16 @@ public void doTag() throws JspException, IOException {
         
         Map<String, String> attributes = new HashMap<String, String>();
         attributes.put("type", "file");
-        attributes.put("name", "file");
+        attributes.put("name", name);
+        if (id != null) {
+            attributes.put("id", id);
+        }
         
         Map<String, String> options = new HashMap<String, String>();
         options.put("resource_type", resourceType);
+        if (tags != null) {
+            options.put("tags", tags);
+        }
         
         String cloudinaryUrl = cloudinary.cloudinaryApiUrl("upload", options);
         
@@ -65,20 +77,20 @@ public void doTag() throws JspException, IOException {
         getJspContext().getOut().println(renderedHtml.toString());
     }
 
-    public void setResourceType(String resourceType) {
-        this.resourceType = resourceType;
+    public void setId(String id) {
+        this.id = id;
     }
     
-    public String GetResourceType() {
-        return resourceType;
+    public String getId() {
+        return id;
     }
     
-    public void setFieldName(String fieldName) {
-        this.fieldName = fieldName;
+    public void setName(String name) {
+        this.name = name;
     }
     
-    public String getFieldName() {
-        return fieldName;
+    public String getName() {
+        return name;
     }
     
     public void setExtraClasses(String extraClasses) {
@@ -89,4 +101,28 @@ public String getExtraClasses() {
         return extraClasses;
     }
     
+    public void setTags(String tags) {
+        this.tags = tags;
+    }
+    
+    public String getTags() {
+        return tags;
+    }
+    
+    public void setFieldName(String fieldName) {
+        this.fieldName = fieldName;
+    }
+    
+    public String getFieldName() {
+        return fieldName;
+    }
+
+    public void setResourceType(String resourceType) {
+        this.resourceType = resourceType;
+    }
+    
+    public String GetResourceType() {
+        return resourceType;
+    }
+    
 }
diff --git a/cloudinary-taglib/src/main/resources/META-INF/cloudinary.tld b/cloudinary-taglib/src/main/resources/META-INF/cloudinary.tld
@@ -15,6 +15,21 @@
             <required>true</required>
             <rtexprvalue>true</rtexprvalue>
         </attribute>
+        <attribute>
+            <name>id</name>
+            <required>false</required>
+            <rtexprvalue>true</rtexprvalue>
+        </attribute>
+        <attribute>
+            <name>name</name>
+            <required>false</required>
+            <rtexprvalue>true</rtexprvalue>
+        </attribute>
+        <attribute>
+            <name>tags</name>
+            <required>false</required>
+            <rtexprvalue>true</rtexprvalue>
+        </attribute>
         <attribute>
             <name>extraClasses</name>
             <required>false</required>
