add support for named transformations as tag attribute

itaibenari · itaibenari · commit d480fce92807 · 2013-11-11T10:26:45.000+02:00
diff --git a/cloudinary-taglib/src/main/java/com/cloudinary/taglib/CloudinaryImageTag.java b/cloudinary-taglib/src/main/java/com/cloudinary/taglib/CloudinaryImageTag.java
@@ -42,6 +42,8 @@ public class CloudinaryImageTag extends SimpleTagSupport implements DynamicAttri
     private Boolean secure = null;
     private Boolean cdnSubdomain = null;
 
+    private String namedTransformation = null;
+
     /** stores the dynamic attributes */
     private Map<String,Object> tagAttrs = new HashMap<String,Object>();
 
@@ -64,7 +66,7 @@ public void doTag() throws JspException, IOException {
         Url url = cloudinary.url();
 
         Transformation baseTransformation = new Transformation().params(tagAttrs);
-
+        if (namedTransformation != null) baseTransformation.named(namedTransformation);
         url.transformation(baseTransformation.chain().rawTransformation(transformation));
         if (format != null) url.format(format);
         if (type != null) url.type(type);
@@ -161,6 +163,14 @@ public void setCdnSubdomain(Boolean cdnSubdomain) {
         this.cdnSubdomain = cdnSubdomain;
     }
 
+    public String getNamed() {
+        return namedTransformation;
+    }
+
+    public void setNamed(String namedTransformation) {
+        this.namedTransformation = namedTransformation;
+    }
+
     @Override
     public void setDynamicAttribute(String uri, String name, Object value) throws JspException {
         tagAttrs.put(name, value);
diff --git a/cloudinary-taglib/src/main/java/com/cloudinary/taglib/CloudinaryUrl.java b/cloudinary-taglib/src/main/java/com/cloudinary/taglib/CloudinaryUrl.java
@@ -31,6 +31,8 @@ public class CloudinaryUrl extends SimpleTagSupport implements DynamicAttributes
     private Boolean secure = null;
     private Boolean cdnSubdomain = null;
 
+    private String namedTransformation = null;
+
     /** stores the dynamic attributes */
     private Map<String,Object> tagAttrs = new HashMap<String,Object>();
 
@@ -44,6 +46,7 @@ public void doTag() throws JspException, IOException {
 
         Url url = cloudinary.url();
         Transformation baseTransformation = new Transformation().params(tagAttrs);
+        if (namedTransformation != null) baseTransformation.named(namedTransformation);
         url.transformation(baseTransformation.chain().rawTransformation(transformation));
         if (format != null) url.format(format);
         if (type != null) url.type(type);
@@ -115,6 +118,14 @@ public void setCdnSubdomain(Boolean cdnSubdomain) {
         this.cdnSubdomain = cdnSubdomain;
     }
 
+    public String getNamed() {
+        return namedTransformation;
+    }
+
+    public void setNamed(String namedTransformation) {
+        this.namedTransformation = namedTransformation;
+    }
+
     @Override
     public void setDynamicAttribute(String uri, String name, Object value) throws JspException {
         tagAttrs.put(name, value);
diff --git a/cloudinary-taglib/src/main/resources/META-INF/cloudinary.tld b/cloudinary-taglib/src/main/resources/META-INF/cloudinary.tld
@@ -196,6 +196,11 @@
             <required>false</required>
             <rtexprvalue>true</rtexprvalue>
         </attribute>
+        <attribute>
+            <name>named</name>
+            <required>false</required>
+            <rtexprvalue>true</rtexprvalue>
+        </attribute>
         <dynamic-attributes>true</dynamic-attributes>
     </tag>
     <tag>
@@ -237,6 +242,11 @@
             <required>false</required>
             <rtexprvalue>true</rtexprvalue>
         </attribute>
+        <attribute>
+            <name>named</name>
+            <required>false</required>
+            <rtexprvalue>true</rtexprvalue>
+        </attribute>
         <dynamic-attributes>true</dynamic-attributes>
     </tag>
     <tag>
