fix: extend Services class with CodeIgniter's BaseService#198
Merged
michalsn merged 2 commits intocodeigniter4:developfrom Nov 23, 2025
Merged
fix: extend Services class with CodeIgniter's BaseService#198michalsn merged 2 commits intocodeigniter4:developfrom
michalsn merged 2 commits intocodeigniter4:developfrom
Conversation
Pull Request Test Coverage Report for Build 19601730262Details
💛 - Coveralls |
Member
|
Thank you. Can you remove the rule: |
Contributor
Author
|
Done! Also fixed some rector issues along the way. Thank you for the review. |
Member
|
I'm a bit lost with this Rector error. |
Member
|
That seems due to You can skip it for now while wait for next release, add this under: \Rector\PHPUnit\CodeQuality\Rector\StmtsAwareInterface\DeclareStrictTypesTestsRector::class, |
Member
|
Awesome. Thank you @samsonasik! |
michalsn
approved these changes
Nov 23, 2025
Member
|
Thank you @yassinedoghri |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi, I stumbled on this issue when using phpstan-codeigniter:
Internal error: Services factory class "CodeIgniter\Tasks\Config\Services" does not extend CodeIgniter\Config\BaseService.Tasks services don't extend the right
CodeIgniter\Config\BaseServiceclass as they should.This PR fixes it. Thank you!