Skip to content

fix: return value for runQueue()#189

Merged
michalsn merged 2 commits intocodeigniter4:developfrom
michalsn:fix/queue
Jul 4, 2025
Merged

fix: return value for runQueue()#189
michalsn merged 2 commits intocodeigniter4:developfrom
michalsn:fix/queue

Conversation

@michalsn
Copy link
Member

@michalsn michalsn commented Jul 4, 2025

Description
This PR updates how we handle the return value of runQueue(). Since queueing now returns a QueuePushResult object, we need to call getStatus() to retrieve the actual result.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn added the bug Something isn't working label Jul 4, 2025
@coveralls
Copy link

coveralls commented Jul 4, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 16075504354

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.252%
Totals Coverage Status
Change from base Build 15366160818: 0.0%
Covered Lines: 367
Relevant Lines: 469
💛 - Coveralls

paulbalandan
paulbalandan reviewed Jul 4, 2025
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add also the return PHPDoc for the runQueue() so it can be tracked by static analysis in the future?

@michalsn
Copy link
Member Author

michalsn commented Jul 4, 2025

Done.

paulbalandan
paulbalandan approved these changes Jul 4, 2025
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@michalsn michalsn merged commit 1b76ab3 into codeigniter4:develop Jul 4, 2025
27 checks passed
@michalsn
Copy link
Member Author

michalsn commented Jul 4, 2025

Thank you @paulbalandan and @datamweb

@michalsn michalsn deleted the fix/queue branch July 12, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

+1 more reviewer

@datamweb datamweb datamweb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michalsn @coveralls @datamweb @paulbalandan